Fix action sheet callback invoked more than once on iPad #33099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: f89a0b7 |
Base commit: f89a0b7 |
|
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
philIip
requested changes
Feb 14, 2022
| // The handler for a button might get called more than once when tapping outside | ||
| // the action sheet on iPad. RCTResponseSenderBlock can only be called once so | ||
| // keep track of callback invocation here. | ||
| __block bool callbackInvoked = false; |
There was a problem hiding this comment.
this is never set to true? the condition in L146 will always pass. am i missing something obvious?
There was a problem hiding this comment.
Oh you're right, my bad I removed it to test before / after and forgot to put it back -_-
|
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
philIip
approved these changes
Feb 16, 2022
|
This pull request was successfully merged by @janicduplessis in 8935d6e. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
) Summary: iOS will sometimes invoke the UIAlertAction handler for the cancel button more than once on iPad. This can be reproduced relatively easily by having a button that opens an action sheet and spam tapping outside the action sheet while it is opening. Since native module callbacks can only be invoked once this causes the app to crash here https://github.com/facebook/react-native/blob/main/ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.mm#L206. ## Changelog [iOS] [Fixed] - Fix action sheet callback invoked more than once on iPad Pull Request resolved: facebook#33099 Test Plan: Tested on iPad simulator to reproduce the crash and verified that this fixes it. Reviewed By: philIip Differential Revision: D34215327 Pulled By: ShikaSD fbshipit-source-id: 6f406e4df737a57e6dd702dd54260aa72eab31d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
iOS will sometimes invoke the UIAlertAction handler for the cancel button more than once on iPad. This can be reproduced relatively easily by having a button that opens an action sheet and spam tapping outside the action sheet while it is opening. Since native module callbacks can only be invoked once this causes the app to crash here https://github.com/facebook/react-native/blob/main/ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModule.mm#L206.
Changelog
[iOS] [Fixed] - Fix action sheet callback invoked more than once on iPad
Test Plan
Tested on iPad simulator to reproduce the crash and verified that this fixes it.