Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the SegmentedComponentIOS away from React Native Core #33140

Closed
wants to merge 1 commit into from
Closed

Move the SegmentedComponentIOS away from React Native Core #33140

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Feb 18, 2022 •
edited
Loading

Summary: This Diff moves the SegmentedComponentIOS away from the core of React Native to move forward with the Lean Core effort

Changelog

[General][Removed] - This diff removes the SegmentedControlIOS export from React Native. Internally, we are requiring SegmentedControlIOS directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Differential Revision: D34304255

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 18, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34304255

@pull-bot
Copy link

pull-bot commented Feb 18, 2022 •
edited
Loading

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against f643a76

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 16feabf
Branch: main

@facebook-github-bot
Move the SegmentedComponentIOS away from React Native Core (faceboo…
f643a76 
…k#776)

Summary:
Pull Request resolved: facebook/metro#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Differential Revision: D34304255

fbshipit-source-id: 8688b75a7c1300359470df36072e99e5c06c2bef
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34304255

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,184,318 -3,729
android hermes armeabi-v7a 7,785,616 -2,557
android hermes x86 8,554,473 -3,522
android hermes x86_64 8,507,231 -3,805
android jsc arm64-v8a 9,854,016 -3,428
android jsc armeabi-v7a 8,839,857 -2,256
android jsc x86 9,820,269 -3,230
android jsc x86_64 10,417,145 -3,516

Base commit: 16feabf
Branch: main

cortinico
cortinico reviewed Feb 18, 2022
View reviewed changes
index.js Show resolved Hide resolved
facebook-github-bot pushed a commit that referenced this pull request Feb 21, 2022
@facebook-github-bot
Move the SegmentedComponentIOS away from React Native Core (#33140)
235f168 
Summary:
Pull Request resolved: #33140

Pull Request resolved: facebook/metro#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Reviewed By: cortinico

Differential Revision: D34304255

fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 235f168.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 21, 2022
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this pull request Mar 14, 2022
@nevilm-lt
Move the SegmentedComponentIOS away from React Native Core (#33140)
d51d1ee 
Summary:
Pull Request resolved: facebook/react-native#33140

Pull Request resolved: facebook#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Reviewed By: cortinico

Differential Revision: D34304255

fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this pull request Apr 21, 2022
@nevilm-lt
Move the SegmentedComponentIOS away from React Native Core (#33140)
9d6a3e1 
Summary:
Pull Request resolved: facebook/react-native#33140

Pull Request resolved: facebook#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Reviewed By: cortinico

Differential Revision: D34304255

fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
nevilm-lt pushed a commit to nevilm-lt/metro that referenced this pull request Apr 22, 2022
@nevilm-lt
Move the SegmentedComponentIOS away from React Native Core (#33140)
e35ca10 
Summary:
Pull Request resolved: facebook/react-native#33140

Pull Request resolved: facebook#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Reviewed By: cortinico

Differential Revision: D34304255

fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@Saadnajmi
Move the SegmentedComponentIOS away from React Native Core (faceboo…
20f2041 
…k#33140)

Summary:
Pull Request resolved: facebook#33140

Pull Request resolved: facebook/metro#776

This Diff moves the `SegmentedComponentIOS` away from the core of React Native to move forward with the Lean Core effort

## Changelog
[General][Removed] - This diff removes the `SegmentedControlIOS` export from React Native. Internally, we are requiring `SegmentedControlIOS` directly now and externally people will have to use the community maintained module (https://github.com/react-native-segmented-control).

Reviewed By: cortinico

Differential Revision: D34304255

fbshipit-source-id: d4e2b0bda56708769603be6f164e6bf89997fd93
@ecreeth ecreeth mentioned this pull request Apr 10, 2024
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 17, 2024
@ecreeth @facebook-github-bot
remove: leftover RCTSegmentedControl code (#44023)
66fd1e8 
Summary:
The `SegmentedControl` component was removed in #33140, but not all related code was moved.

See React Native 0.69 breaking-changes:  https://reactnative.dev/blog/2022/06/21/version-069#breaking-changes

## Changelog:

[INTERNAL] - remove: leftover `RCTSegmentedControl` code

Pull Request resolved: #44023

Test Plan: CI will be OK.

Reviewed By: cortinico

Differential Revision: D56015121

Pulled By: dmytrorykun

fbshipit-source-id: 10e64e9bbd0e5346711fd2f42553deb2d992c191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Type: Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cipolleschi @facebook-github-bot @pull-bot @analysis-bot @react-native-bot @cortinico