-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump CLI version to 7.0.3 to address web debugging issue #33156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
Feb 21, 2022
thymikee
reviewed
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @kelset in df2e934. When will my fix make it into a release? | Upcoming Releases |
ShikaSD
pushed a commit
that referenced
this pull request
Feb 24, 2022
…#33156) Summary: Doing this patch level bump to ensure that all packages consuming `react-native` will get `7.0.3` and not lower 7.x versions. This is because this new patch contains this fix: react-native-community/cli#1560 (thanks NickGerleman & thymikee for your work!) We'll have to cherry-pick this into the 0.68 branch. While at it, I've also done a cheeky `npx yarn-deduplicate` to clean up the `yarn.lock` a bit. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - Bump RN CLI to v7.0.3 to address web debugging issue Pull Request resolved: #33156 Test Plan: CI + some local testing via `test-manual-e2e`: <img width="1779" alt="Screenshot 2022-02-21 at 11 40 54" src="https://user-images.githubusercontent.com/16104054/154948695-8c40bb56-87eb-4326-a740-49930994c08b.png"> Reviewed By: cortinico Differential Revision: D34385503 Pulled By: motiz88 fbshipit-source-id: f0d8c4e0e92f83c0d819eeaa0fbec27820145968
ShikaSD
pushed a commit
that referenced
this pull request
Feb 24, 2022
…#33156) Summary: Doing this patch level bump to ensure that all packages consuming `react-native` will get `7.0.3` and not lower 7.x versions. This is because this new patch contains this fix: react-native-community/cli#1560 (thanks NickGerleman & thymikee for your work!) We'll have to cherry-pick this into the 0.68 branch. While at it, I've also done a cheeky `npx yarn-deduplicate` to clean up the `yarn.lock` a bit. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - Bump RN CLI to v7.0.3 to address web debugging issue Pull Request resolved: #33156 Test Plan: CI + some local testing via `test-manual-e2e`: <img width="1779" alt="Screenshot 2022-02-21 at 11 40 54" src="https://user-images.githubusercontent.com/16104054/154948695-8c40bb56-87eb-4326-a740-49930994c08b.png"> Reviewed By: cortinico Differential Revision: D34385503 Pulled By: motiz88 fbshipit-source-id: f0d8c4e0e92f83c0d819eeaa0fbec27820145968
This was referenced Apr 21, 2022
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
…facebook#33156) Summary: Doing this patch level bump to ensure that all packages consuming `react-native` will get `7.0.3` and not lower 7.x versions. This is because this new patch contains this fix: react-native-community/cli#1560 (thanks NickGerleman & thymikee for your work!) We'll have to cherry-pick this into the 0.68 branch. While at it, I've also done a cheeky `npx yarn-deduplicate` to clean up the `yarn.lock` a bit. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - Bump RN CLI to v7.0.3 to address web debugging issue Pull Request resolved: facebook#33156 Test Plan: CI + some local testing via `test-manual-e2e`: <img width="1779" alt="Screenshot 2022-02-21 at 11 40 54" src="https://user-images.githubusercontent.com/16104054/154948695-8c40bb56-87eb-4326-a740-49930994c08b.png"> Reviewed By: cortinico Differential Revision: D34385503 Pulled By: motiz88 fbshipit-source-id: f0d8c4e0e92f83c0d819eeaa0fbec27820145968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
Merged
This PR has been merged.
p: Microsoft
Partner: Microsoft
Partner
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Doing this patch level bump to ensure that all packages consuming
react-native
will get7.0.3
and not lower 7.x versions.This is because this new patch contains this fix: react-native-community/cli#1560
(thanks @NickGerleman & @thymikee for your work!)
We'll have to cherry-pick this into the 0.68 branch.
While at it, I've also done a cheeky
npx yarn-deduplicate
to clean up theyarn.lock
a bit.Changelog
[General] [Changed] - Bump RN CLI to v7.0.3 to address web debugging issue
Test Plan
CI + some local testing via
test-manual-e2e
: