Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kotlin_home and related JARs for OSS Buck Kotlin build #33168

Closed
wants to merge 1 commit into from
Closed

Add kotlin_home and related JARs for OSS Buck Kotlin build #33168

wants to merge 1 commit into from

Conversation

ShikaSD
Copy link
Contributor

@ShikaSD ShikaSD commented Feb 23, 2022

Differential Revision: D34419817

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 23, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

@pull-bot
Copy link

pull-bot commented Feb 23, 2022 •
edited
Loading

Fails
🚫

❔ This pull request needs a description.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 72392ea

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b1a7793
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

ShikaSD pushed a commit to ShikaSD/react-native that referenced this pull request Feb 23, 2022
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
956e7f5 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: adedde9ec63c1d8afd0378ce7dfd054bea85e61b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

ShikaSD pushed a commit to ShikaSD/react-native that referenced this pull request Feb 23, 2022
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
f5b9951 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: 90b99ed19f1413aa0c29b15158f926fbab47623f
ShikaSD pushed a commit to ShikaSD/react-native that referenced this pull request Feb 23, 2022
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
6cd8a0c 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: 059bbc58be9f4ee22004dbab76b14e79700a5c85
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

ShikaSD pushed a commit to ShikaSD/react-native that referenced this pull request Feb 23, 2022
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
127349c 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: 062df342d3deb4c7f6542041e862df1660be5de2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

ShikaSD pushed a commit to ShikaSD/react-native that referenced this pull request Feb 23, 2022
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
29fab33 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: dd4e90ae937d0ea3e6245ea02be5ea7ec9e9d4db
@facebook-github-bot
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
72392ea 
…33168)

Summary: Pull Request resolved: facebook#33168

Differential Revision: D34419817

fbshipit-source-id: 904208fe66656ef7f90d08afed68bcd0221e7f5c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34419817

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,203,198 +13,097
android hermes armeabi-v7a 7,810,241 +14,071
android hermes x86 8,575,361 +15,772
android hermes x86_64 8,525,971 +14,445
android jsc arm64-v8a 9,871,938 +12,027
android jsc armeabi-v7a 8,863,529 +13,022
android jsc x86 9,840,192 +14,721
android jsc x86_64 10,434,928 +13,374

Base commit: b1a7793
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ShikaSD in 8b226f9.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 24, 2022
@friederbluemle friederbluemle mentioned this pull request Feb 25, 2022
Closed
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@Saadnajmi
Add kotlin_home and related JARs for OSS Buck Kotlin build (facebook#…
64ea552 
…33168)

Summary:
Pull Request resolved: facebook#33168

Buck Kotlin setup requires jars to be available locally before the build, so we are checking them in.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D34419817

fbshipit-source-id: 5e75f0f3818fb76b640349c003bd258bc12aa53d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShikaSD @facebook-github-bot @pull-bot @analysis-bot @react-native-bot