calling setError does not display an error if the TextInput is a
controlled component.

https://reactnative.dev/docs/textinput#value
>The value to show for the text input. TextInput is a controlled component, which means the native value will be forced to match this value prop if provided. For most uses, this works great, but in some cases this may cause flickering - one common cause is preventing edits by keeping value the same. In addition to setting the same value, either set editable={false}, or set/update maxLength to prevent unwanted edits without flicker.

```javascript
function ErrorExample(): React.Node {
  const [text, setText] = React.useState('');
  const [error, setError] = React.useState(null);
  return (
    <TextInput
      errorMessage={error}
      onChangeText={newText => {
        setText(newText);
        setError(newText === 'error' ? 'this input is invalid' : null);
      }}
      value={text}
    />
  );
}
```

The solution from pr facebook#28952
fixes this issue and forces the update by invalidating the TextInput
instance which triggers onAttachedToWindow()

To be noticed that there is logic to trigger this updates in the
ReactTextInputManager
https://github.com/fabriziobertoglio1987/react-native/blob/60b6c9be8e811241039a6db5dc906a0e88e6ba82/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java#L1291-L1292

The PR was previously accepted and could be an acceptable solution for
this issue

…: folly_json

```
  /home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:651: Android NDK: Module react_codegen_rncore depends on undefined modules: folly_json
  /home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:664: *** Android NDK: Note that old versions of ndk-build silently ignored this error case. If your project worked on those versions, the missing libraries were not needed and you can remove those dependencies from the module to fix your build. Alternatively, set APP_ALLOW_MISSING_DEPS=true to allow missing dependencies.    .  Stop.
```

I applied solution in https://stackoverflow.com/a/48897133/7295772
but now caused this error

```
  make: *** [/home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:725: /home/fabrizio/.gradle/build/react-native-github/ReactAndroid/intermediates/cxx/Debug/83t124q6/obj/local/x86/libreact_codegen_rncore.so] Error 1
  make: *** Waiting for unfinished jobs....
```

Full Logs

```
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ReactAndroid:configureNdkBuildDebug[x86]'.
> [CXX1405] error when building with ndkBuild using /home/fabrizio/Documents/sourcecode/opensource/react-native/ReactAndroid/src/main/jni/react/jni/Android.mk: Build command failed.
  Error while executing process /home/fabrizio/Android/Sdk/ndk/21.4.7075529/ndk-build with arguments {NDK_PROJECT_PATH=null APP_BUILD_SCRIPT=/home/fabrizio/Documents/sourcecode/opensource/react-native/ReactAndroid/src/main/jni/react/jni/Android.mk NDK_GRADLE_INJECTED_IMPORT_PATH=/home/fabrizio/.gradle/build/react-native-github/ReactAndroid/.cxx/Debug/83t124q6/prefab/x86 APP_ABI=x86 NDK_ALL_ABIS=x86 NDK_DEBUG=1 APP_PLATFORM=android-21 NDK_OUT=/home/fabrizio/.gradle/build/react-native-github/ReactAndroid/intermediates/cxx/Debug/83t124q6/obj NDK_LIBS_OUT=/home/fabrizio/.gradle/build/react-native-github/ReactAndroid/intermediates/cxx/Debug/83t124q6/lib NDK_APPLICATION_MK=/home/fabrizio/Documents/sourcecode/opensource/react-native/ReactAndroid/src/main/jni/Application.mk THIRD_PARTY_NDK_DIR=/home/fabrizio/.gradle/build/react-native-github/ReactAndroid/third-party-ndk REACT_COMMON_DIR=/home/fabrizio/Documents/sourcecode/opensource/react-native/ReactAndroid/../ReactCommon REACT_GENERATED_SRC_DIR=/home/fabrizio/.gradle/build/react-native-github/ReactAndroid/generated/source REACT_SRC_DIR=/home/fabrizio/Documents/sourcecode/opensource/react-native/ReactAndroid/src/main/java/com/facebook/react APP_STL=c++_shared -j8 APP_SHORT_COMMANDS=false LOCAL_SHORT_COMMANDS=false -B -n}

  /home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:651: Android NDK: Module react_codegen_rncore depends on undefined modules: folly_json
  /home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:664: *** Android NDK: Note that old versions of ndk-build silently ignored this error case. If your project worked on those versions, the missing libraries were not needed and you can remove those dependencies from the module to fix your build. Alternatively, set APP_ALLOW_MISSING_DEPS=true to allow missing dependencies.    .  Stop.
```

```
  ../ReactCommon/react/nativemodule/core/../../../react/renderer/core/RawValue.h:249: error: undefined reference to 'folly::dynamic::size() const'
  /home/fabrizio/.gradle/build/react-native-github/ReactAndroid/third-party-ndk/folly/folly/dynamic-inl.h:356: error: undefined reference to 'folly::dynamic::operator=(folly::dynamic&&)'
  ../ReactCommon/react/nativemodule/core/../../../react/renderer/core/RawValue.h:249: error: undefined reference to 'folly::dynamic::size() const'
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [/home/fabrizio/Android/Sdk/ndk/21.4.7075529/build/core/build-binary.mk:725: /home/fabrizio/.gradle/build/react-native-github/ReactAndroid/intermediates/cxx/Debug/83t124q6/obj/local/x86/libreact_codegen_rncore.so] Error 1
  make: *** Waiting for unfinished jobs....
```

… modules: folly_json"

This reverts commit 06c4908.

allow to display error message on TextInput triggered in a onChangeText
callback. Fixes issue explained in:
fabOnReact/react-native-notes#12 (comment)

Related links:
fabOnReact/react-native-notes#12 (comment)
d3d54e1

Following same implementation used with underlineColorAndroid
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/TextInput.js#L470
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/AndroidTextInputNativeComponent.js#L203

While with other components (for example prop android_ripple), we use
the android_ prefix to denote platform specific props.
facebook#29157 (comment)
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/Pressable/Pressable.js#L177

In the case of TextInput we already have Platform Logic that detects
Android/iOS platform.
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/TextInput.js#L1268

For this reason TextInput component does not use android_ props and
instead uses this naming convention underlineColorAndroid.

To be noted that the prop underlineColorAndroid is passed to both iOS
and Android version, while other props have platform specific logic for
android and iOS.
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/TextInput.js#L1334
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/TextInput.js#L1293

Example of a prop that have a specific value on Android and is different
from iOS
https://github.com/fabriziobertoglio1987/react-native/blob/15810e96d90e18dbd424666338fdec0127d403ed/Libraries/Components/TextInput/TextInput.js#L1271

I decided to follow the same solution used in underlineColorAndroid.

…Input state)

- remove errorMessage from ReactTextUpdate constructor
  mErrorMessage is set with buildReactTextUpdateFromState
- errorMessage is part of the AndroidTextInputState.cpp field
  ParagraphAttributes.errorMessageAndroid
- maybeSetErrorMessage is triggered from c++ state changes of text

Relevant Links

facebook#33468 (review)
fabOnReact/react-native-notes#12 (comment)
fabOnReact/react-native-notes#12 (comment)

fabOnReact/react-native-notes#12 (comment)
fabOnReact/react-native-notes#12 (comment)
fabOnReact/react-native-notes#12 (comment)

rawProps collection has null value for the key. This is the special case which means that the prop was removed from the particular component instance and we have to reset it to some default value (which is not the same as sourceValue). Now the default value of the defaultValue (sic!) argument is a default value of the type of the value (which may be different from logical default value).

fabOnReact/react-native-notes#12 (comment)
fabOnReact/react-native-notes#12 (comment)

>A pointer however, is a variable that stores the memory address as its value.
>A pointer variable points to a data type (like int or string) of the same type, and is created with the * operator. The address of the variable you're working with is assigned to the pointer:
https://www.w3schools.com/cpp/cpp_pointers.asp

The solution was copied by allowFontScaling
```c++
  if (textAttributes.allowFontScaling.has_value()) {
    _textAttributes("allowFontScaling", *textAttributes.allowFontScaling);
  }
```
https://github.com/fabriziobertoglio1987/react-native/blob/53fe1c0d12b7d711819d3b79aac6eb99568cf86d/ReactCommon/react/renderer/attributedstring/conversions.h#L868

to solve the fat that folly::object() takes two parameters key and
value. The value can not be of type std::optional<std::string>

https://github.com/facebook/folly/blob/main/folly/docs/Dynamic.md

conversion to string with
folly::to<std::string>(paragraphAttributes.errorMessageAndroid) does not
work.

This solution first checks if paragraphAttributes.errorMessageAndroid is
not null with method has_value and then used value_or("").

facebook#33468 (review)

maybeSetErrorMessage is called every time we change the errorMessageAndroid TextInput prop. This causes issues when triggering the errorMessage outside of onChangeText callback. Could not yet reproduce on fabric.

Issue documented in comment facebook#33468 (comment)

calling requestSendAccessibilityEvent fixes the issue
the logic was taken from TextView#setError which calls notifyViewAccessibilityStateChangedIfNeeded
https://github.com/aosp-mirror/platform_frameworks_base/blob/1ac46f932ef88a8f96d652580d8105e361ffc842/core/java/android/widget/TextView.java#L7284

after some testing, calling the requestSendAccessibilityEvent on the
parent view fixed the issue

```
mParent.requestSendAccessibilityEvent(this, event)
```
https://github.com/aosp-mirror/platform_frameworks_base/blob/1ac46f932ef88a8f96d652580d8105e361ffc842/core/java/android/view/View.java#L13710

the check caused the error to be announced twice

iOS has no standard pattern for the presentation of error states on text inputs, so I'd recommend we follow Android's pattern here. To do this, you'll need to implement a key press listener, and on change, detect if the field is now in an error state. If it is, you'll need to make a manual screen reader announcement of the error message, and append this message to the accessibilityValue for the field.

This reverts commit ea9bb4c.

reapply the previous solution after doing a reset of the branch
changes deleted are saved in branch

https://github.com/facebook/react-native/compare/main...fabriziobertoglio1987:text-input-errors-set-text-and-selection?expand=1

Moving the head back to this commit
facebook@29b99ba

Reapply the solution for iOS announcing multiple times the errorMessage
facebook@e0bdf61
facebook@3467c5d

A similar problem was also detected on Android and solved with a similar
solution
fabOnReact/react-native-notes#12 (comment)

The reset was done to remove the changes to the implementation which
would use codegen.setTextAndSelection() instead of adding the prop to
c++

Explained in detail here
fabOnReact/react-native-notes#12 (comment)

we have 2 types of data flow in the TextInput

SCENARIO 1
Javascript  <--->  Native Android/iOS

JavaScript receives in callback like onChangeText updates on the value
of the text and selection position, then decides with an onLayoutEffect
callback to over-ride those updates with the value kept in internal
state. This is how JavaScript TextInput component works.

SCENARIO 2
CPP <----> Native Android/iOS

The state in CPP/Android/iOS keeps in sync.

In this case, we don't receive any native update from Android/iOS on the
value of the screenreaderError in Native side (not like for example the
text value which is passed back to JavaScript with the _onChange
callback).
https://github.com/fabriziobertoglio1987/react-native/blob/f2e23215ca14c3c630aa931cdd114187589ac0fb/Libraries/Components/TextInput/TextInput.js#L1115

For this reason, I don't think is a good idea including the
screenreaderError in the setTextAndSelection.

if (oldProps.screenreaderError != newProps.screenreaderError) {
  ~~~~~~~~ ^
    /app/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/viewPropConversions.h:280:46: error: no member named 'screenreaderError' in 'facebook::react::ViewProps'
    if (oldProps.screenreaderError != newProps.screenreaderError) {
      ~~~~~~~~ ^
        /app/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/viewPropConversions.h:281:56: error: no member named 'screenreaderError' in 'facebook::react::ViewProps'
        builder.putString(VP_ACCESSIBILITY_LABEL, newProps.screenreaderError);

https://app.circleci.com/pipelines/github/facebook/react-native/13468/workflows/1d3a4607-2b60-4e47-8524-16dec4eb9c83/jobs/255735
https://app.circleci.com/pipelines/github/facebook/react-native/13468/workflows/1d3a4607-2b60-4e47-8524-16dec4eb9c83/jobs/255758

Still not clear to me the logic behind this functionality, but could not
trigger the viewPropsDiff method with TextInput onChangeText
733f228

The below method is triggered but did not have the time to further
investigate, adding this diffing mechanism could be an improvement to
add to the pr in the future
https://github.com/fabriziobertoglio1987/react-native/blob/d96a2845fbb17dac390719c1613a108ec3987f62/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java#L45

as already used on the iOS side of this functionalities
https://github.com/facebook/react-native/pull/33468/files#diff-589692b2662a9e15ae1a961b98289ba4c4b0231d448e985066a29c68f617db5fR137-R148

grep "screenreader_error" **/*.xml
grep "screenreaderError" **/*.(js|mm|m|cpp|h|java)
bufdo %s/screenreaderError/accessibilityErrorMessage/gce
bufdo %s/screenreader_error/accessibility_error_message/gce
bufdo %s/mScreenreaderError/mAccessibilityErrorMessage/gce

accessibilityInvalid will remove the accessibilityErrorMessage

when deleting text, the accessibilityValue is not set to the value of
the text. For example

Erro => Erro
Error => Error, the new text is Error (announcing error)
Erro => Erro
Err => nothing (should be Err)
Er => nothing (should be Er)
E => nothing (should be E)

when we move focus out/back, the announcement is Erro, even if the
text is (E, Er or Err)

after the fix

Erro => Erro
Error => Error, the new text is Error (announcing error)
Erro => Erro
Err => Err
Er => Er
E => E

- errorMessage does not change => the errorMessage should update with
  the new text value
  This is fixed by adding check on the text value change
- errorMessage is cleared (null) => accessibilityValue is reset to text
  value

…ccessibilityErrorMessage:]: unrecognized selector sent to instance (Paper)

<image src="https://user-images.githubusercontent.com/24992535/173279577-98f1e7e2-dda8-4c25-b834-cb8b7933a522.jpeg" width="300" />

1) include the UITextField text value in the error message
   (accessibilityValue)
2) avoid repeating error 2 times (on Error and then again Errore)

Still not working, when we stop invoking setAccessibilityErrorMessage,
the accessibilityValue does not update anymore.
We should find the onChangeText callback to update the
accessibilityValue in that callback every time the text is edited.

Moving logic to RCTBaseTextInputView method setAttributedText
responsible to update text onChangeText on Paper iOS.

On every character type the accessibilityValue is set to the text value
or the text value + error message.

1) Erro => Error
   The user types Error. Currently the Screenreader on iOS announces
   Error, The new text is Error.
   But the correct behaviour is r, The new text is Error
2) Error => Erro
   The user deletes 1 char from the previous example. The Screenreader
   would announce Erro.

Issue 1) and 2) are caused by calling UIAccessibilityPostNotification to
trigger the voiceover announcement with the entire TextInput text value,
instead of using just the last char of the TextInput text.

3) Outside of onChangeText, the TextInput accessibilityValue should be
   set to the entire TextInput value ("Error" and not "r").

Point 3) is accomplished by setting the accessibilityValue to the
value TextInput text ("Error" and not "r") + the error message.