-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ruby to 2.7.5 #33485
Bump ruby to 2.7.5 #33485
Conversation
Base commit: 184dfb8 |
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good but I would hold-on on this till master is green again. @hramos is already aware of it and is looking into it.
Just want to make sure we don't break things even further
7a83c17
to
6482b58
Compare
Base commit: 184dfb8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This time the CI failure is a flaky test so we should be good to go
@GijsWeterings has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico as @mikehardy mentioned in reactwg/react-native-releases#19 (reply in thread) it might be worthwhile to bump straight to the newest version of ruby instead of just the newest in the 2.7 release. What do you think? Are there any internal reasons to stay on 2.7? |
I'm trying to learn if from the MSFT side of things we have some specific requirements about Ruby (for now, I couldn't find anything), but in the meantime I'm looking at the Ruby website:
But I'm still asking around MSFT internally to learn if there's any reason why we might want to stay on 2.7 so take what I'm saying with a pinch of salt |
I don't see any blockers on top of my mind. I believe we're good to go, as long as it concerns the iOS build pipeline. I would however suggest we:
The reason is that it might not make it into 0.69.x and I believe we can anyway land this PR regardless 👍 |
@cortinico Thanks for the feedback. Sounds like a plan. |
This pull request was successfully merged by @danilobuerger in 2c87b74. When will my fix make it into a release? | Upcoming Releases |
Summary: This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/) [iOS] [Changed] - Bump ruby to 2.7.5 Pull Request resolved: facebook#33485 Test Plan: no test plan, should just pass tests. Reviewed By: cortinico Differential Revision: D35116757 Pulled By: GijsWeterings fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
Bump ruby to 2.7.5 (facebook#33485)
Summary: This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/) Edit: Bumping to 2.7.7 which is the latest today. [iOS] [Changed] - Bump ruby to 2.7.5 Pull Request resolved: facebook/react-native#33485 Test Plan: no test plan, should just pass tests. Reviewed By: cortinico Differential Revision: D35116757 Pulled By: GijsWeterings fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
Summary: This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/) [iOS] [Changed] - Bump ruby to 2.7.5 Pull Request resolved: facebook#33485 Test Plan: no test plan, should just pass tests. Reviewed By: cortinico Differential Revision: D35116757 Pulled By: GijsWeterings fbshipit-source-id: a8e96bfcc6086b70dac21aee24bae46fe6b072bb
Summary
This bumps ruby to the latest 2.7.x versions which includes bug fixes and 3 CVEs (https://www.ruby-lang.org/en/news/2021/11/24/ruby-2-7-5-released/)
Changelog
[iOS] [Changed] - Bump ruby to 2.7.5
Test Plan
no test plan, should just pass tests.