Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RN CLI to v8 alpha #33610

Closed
wants to merge 1 commit into from
Closed

Conversation

thymikee
Copy link
Contributor

Summary

Upgrades the React Native CLI to v8 alpha. This version removes manual linking configuration and a few other things, hence changes to the project configuration.

cc @kelset @fortmarek

Changelog

[General] [Changed] - Upgrade RN CLI to v8 alpha

Test Plan

CI green.

@thymikee thymikee requested a review from hramos as a code owner April 11, 2022 13:24
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Apr 11, 2022
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

@thymikee thanks for sending this over 👍

Just cross checking, we want this included inside 0.69? I'm a bit concerned about shipping a stable version of RN with the CLI on -alpha. Are we planning to land CLI 8 stable before RN 0.69 stable hits NPM?

@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 79f35ae

@thymikee
Copy link
Contributor Author

@cortinico yep, we'd like it to land in v0.69. There are no functional changes planned for v8, maybe some warning messages or such for deprecations. We plan to promote it to stable before 0.69 hits its final RC

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 65abc36
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,770,560 +0
android hermes armeabi-v7a 7,176,577 +0
android hermes x86 8,079,751 +0
android hermes x86_64 8,058,467 +0
android jsc arm64-v8a 9,645,279 +0
android jsc armeabi-v7a 8,419,644 +0
android jsc x86 9,594,494 +0
android jsc x86_64 10,191,921 +0

Base commit: 65abc36
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @thymikee in 7dceb9b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 12, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
Upgrades the React Native CLI to v8 alpha. This version removes manual linking configuration and a few other things, hence changes to the project configuration.

cc kelset fortmarek

[General] [Changed] - Upgrade RN CLI to v8 alpha

Pull Request resolved: facebook#33610

Test Plan: CI green.

Reviewed By: rubennorte

Differential Revision: D35547624

Pulled By: cortinico

fbshipit-source-id: 4de9f280f9d1949c94057c32568b3fdfa4ee6a73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants