Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up lint errors under react-native-github #33622

Closed
wants to merge 2 commits into from

Conversation

lunaleaps
Copy link
Contributor

Summary: Changelog: [Internal] Clean up eslint errors

Differential Revision: D35599445

Luna Wei added 2 commits April 12, 2022 17:11
Differential Revision: D35590075

fbshipit-source-id: 39c304079231ff57f5e5ee4e551367337d2fefd1
Summary: Changelog: [Internal] Clean up eslint errors

Differential Revision: D35599445

fbshipit-source-id: 731b1466cd36dc70def8251387ab0c9ba1fd3726
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 13, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D35599445

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 86f8d0b
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,773,761 -136
android hermes armeabi-v7a 7,179,684 -140
android hermes x86 8,082,925 -139
android hermes x86_64 8,061,536 -138
android jsc arm64-v8a 9,646,934 -53
android jsc armeabi-v7a 8,421,251 -54
android jsc x86 9,596,153 -57
android jsc x86_64 10,193,556 -48

Base commit: 86f8d0b
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @lunaleaps in 6958bbb.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 22, 2022
@lunaleaps lunaleaps deleted the export-D35599445 branch April 25, 2022 16:44
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
Pull Request resolved: facebook#33622

Changelog: [Internal] Clean up eslint errors

Reviewed By: yungsters

Differential Revision: D35599445

fbshipit-source-id: bbb9061a3cf9df32daacad9a9b44eba94d3ce48c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants