Expose private node management methods in UIManager #33688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 21, 2022 09:15
Summary: Minimal set of changes to intercept events in external modules. Current intended use-case is for Reanimated to handle events for the Animated properties. Changelog: [Added] Add listeners to allow intercepting events in C++ core. Differential Revision: D35312534 fbshipit-source-id: 26e505942d7fe34eb41c161e01d8b8af2d0b2d3a
Differential Revision: D35313399 fbshipit-source-id: 3c0d96c6e3ea035aee3d3e05d7570d1746930790
Summary: Exposes event listener through iOS scheduler wrapper (`RCTScheduler`) and exposes scheduler itself through `RCTSurfacePresenter`. Changelog: [Changed] Exposed `RCTScheduler` to allow setting event listeners. Differential Revision: D35313398 fbshipit-source-id: 35143cdbbe74e8c0ba15abcf27ecee33593f4d45
Summary: Pull Request resolved: facebook#33545 Exposes `UIManager` instance for access from third-party modules. Changelog: [Changed] Exposes `UIManager` instance for third-party access. Differential Revision: D35314058 fbshipit-source-id: b80c5520185f272f66788c3392eccecbb2eb1def
Summary: These methods used to be public in the legacy implementation, and hiding them significantly reduces amount of customization available to other clients outside Fabric core. Changelog: [Internal] Allow external callers to call UIManager methods Differential Revision: D35818114 fbshipit-source-id: ba2fb3ba20f95259bb9f1ed9b30d0969cbfe698a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D35818114 |
Base commit: aeac6ab |
tomekzaw
added a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Apr 21, 2022
Base commit: aeac6ab |
|
This pull request was successfully merged by @cortinico in 59385e8. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These methods used to be public in the legacy implementation, and hiding them significantly reduces amount of customization available to other clients outside Fabric core.
Changelog: [Internal] Allow external callers to call UIManager methods
Differential Revision: D35818114