facebook#33690 (comment)

The custom contentDescription should be triggered if:
- an element has no contentDescription **AND** text
- **AND** has other content to announce (role, state, etc.)

the check on the contentDescription is enough also for the accessibilityLabel
https://github.com/fabriziobertoglio1987/react-native/blob/e0e162921c183e4203fd64c35b2f1a29c6e1ef4f/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java#L233

The returned instance is initialized from the given <code>info</code>.

- node.recycle does not trigger runtime as we use
  obtain(AccessibilityNodeInfo info)
- setContentDescription(null) will use the default content description
  (Button, Text number 1, Text number 2) which is the existing behaviour

facebook#33690 (comment)

adding check on hintText in hasText method
the "hint text" for EditText's also counts as content, as it's still announced when the EditText has no text or contentDescription.
See Talkbacks implementation here for reference:
https://github.com/google/talkback/blob/6c0b475b7f52469e309e51bfcc13de58f18176ff/utils/src/main/java/com/google/android/accessibility/utils/AccessibilityNodeInfoUtils.java#L1663
facebook#33690 (comment)

adding check for isScreenReaderFocusable in isAccessibilityFocusable
See Talkback's implementation here for reference:
https://github.com/google/talkback/blob/6c0b475b7f52469e309e51bfcc13de58f18176ff/utils/src/main/java/com/google/android/accessibility/utils/AccessibilityNodeInfoUtils.java#L1690
facebook#33690 (comment)

The regression is caused by the missing logic in
https://github.com/facebook/flipper/blob/e44cad5e9912b359378a43ec47c5a49bbca85fc3/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java#L477-L491

Also needs to verify the following cases with EditText
https://github.com/facebook/flipper/blob/e44cad5e9912b359378a43ec47c5a49bbca85fc3/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java#L500-L516

The previous developed functionality would remove the following
announcements from the child nodes:
- state
- disabled
- accessibilityRole (for the child)

The fields were not retrieved/added to the new Talkback announcement
Fixes regression tested in example
751b83e

the current announcement have been added, the other will follow up in
the next commits:
- state

https://app.circleci.com/pipelines/github/facebook/react-native/13665/workflows/efdceb92-2020-4ca4-8317-f3889b0b7800/jobs/258498

```
Cannot create `TouchableNativeFeedback` element because property `style` is missing in `Props` [1] but exists in
props [2]. [prop-missing]

   packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js:264:16
   264|               <TouchableNativeFeedback
                       ^^^^^^^^^^^^^^^^^^^^^^^

References:
   Libraries/Components/Touchable/TouchableNativeFeedback.js:97:55
    97| class TouchableNativeFeedback extends React.Component<Props, State> {
                                                              ^^^^^ [1]
   packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js:264:15
                      v-----------------------
   264|               <TouchableNativeFeedback
   265|                 style={{
   266|                   height: 100,
   267|                   width: 100,
   268|                   backgroundColor: 'yellow',
   269|                 }}
   270|                 focusable={true}
   271|                 onPress={() => console.warn('onPress child')}
   272|                 accessible={false}
   273|                 accessibilityLabel="this is my label"
   274|                 accessibilityRole="image"
   275|                 accessibilityState={{disabled: true}}
   276|                 accessibilityValue={{text: 'this is the accessibility value'}}>
   277|                 <Text accessible={false}>Text number 3</Text>
   278|               </TouchableNativeFeedback>
                      -------------------------^ [2]

Found 1 error
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Failed to run flow.
Finished.
/home/circleci/react-native/scripts/run-ci-javascript-tests.js:47
    throw Error(exitCode);
    ^

Error: 1
    at Object.<anonymous> (/home/circleci/react-native/scripts/run-ci-javascript-tests.js:47:11)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Exited with code exit status 1
```

facebook@388911e

This reverts commit 8622c13.

if the child has a role defined, it should probably also be accessible on its own,
  and therefore won't get pulled up into its parents announcement in the first place.
facebook#30719 (comment)

based on my personal notes from the last meeting and the below comment
facebook#30719 (comment)

Scenarios:
- 3 levels of nested components 10min
- the contentDescription is not empty and does not have nodeText
- contentDescription is not empty and is not an EditText
- contentDescription is empty, is an EditText and has a nodeText

… the announcement)

from facebook#33690 (comment)

I noticed that getStateDescription returns null even when adding accessibilityState. Calling setStateDescription will update the state description, which is not set via the react accessibilityState or other props.

Seems that the method [setViewState](https://github.com/fabriziobertoglio1987/react-native/blob/ad6732aa3576786d37478a729b112031dd94b682/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java#L254) does not call setStateDescription.

I will further investigate tomorrow.

<details><summary>View#setStateDescription</summary>
<p>

```java
    /**
     * Sets the {@link View}'s state description.
     * <p>
     * A state description briefly describes the states of the view and is primarily used
     * for accessibility support to determine how the states of a view should be presented to
     * the user. It is a supplement to the boolean states (for example, checked/unchecked) and
     * it is used for customized state description (for example, "wifi, connected, three bars").
     * State description changes frequently while content description should change less often.
     * State description should be localized. For android widgets which have default state
     * descriptions, app developers can call this method to override the state descriptions.
     * Setting state description to null restores the default behavior.
     *
     * @param stateDescription The state description.
     * @see #getStateDescription()
     */
    @RemotableViewMethod
    public void setStateDescription(@nullable CharSequence stateDescription) {
        if (mStateDescription == null) {
            if (stateDescription == null) {
                return;
            }
        } else if (mStateDescription.equals(stateDescription)) {
            return;
        }
        mStateDescription = stateDescription;
        if (!TextUtils.isEmpty(stateDescription)
                && getImportantForAccessibility() == IMPORTANT_FOR_ACCESSIBILITY_AUTO) {
            setImportantForAccessibility(IMPORTANT_FOR_ACCESSIBILITY_YES);
        }
        if (AccessibilityManager.getInstance(mContext).isEnabled()) {
            AccessibilityEvent event = AccessibilityEvent.obtain();
            event.setEventType(AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED);
            event.setContentChangeTypes(AccessibilityEvent.CONTENT_CHANGE_TYPE_STATE_DESCRIPTION);
            sendAccessibilityEventUnchecked(event);
        }
    }
```

</p>
</details>

This is the implementation of TalkBack [hasStateDescription](https://github.com/google/talkback/blob/6c0b475b7f52469e309e51bfcc13de58f18176ff/utils/src/main/java/com/google/android/accessibility/utils/AccessibilityNodeInfoUtils.java#L1672-L1677).

The following fields of the view are set with the accessibilityState:

- [checkable](https://github.com/fabriziobertoglio1987/react-native/blob/ad6732aa3576786d37478a729b112031dd94b682/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L411) => BOOLEAN_PROPERTY_CHECKABLE
- [enabled](https://github.com/fabriziobertoglio1987/react-native/blob/ad6732aa3576786d37478a729b112031dd94b682/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L408) => BOOLEAN_PROPERTY_ENABLED

<details><summary>setCheckable</summary>
<p>

https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/accessibility/AccessibilityNodeInfo.java#L2008

```java
  /**
   * Sets whether this node is checkable.
   * <p>
   *   <strong>Note:</strong> Cannot be called from an
   *   {@link android.accessibilityservice.AccessibilityService}.
   *   This class is made immutable before being delivered to an AccessibilityService.
   * </p>
   *
   * @param checkable True if the node is checkable.
   *
   * @throws IllegalStateException If called from an AccessibilityService.
   */
  public void setCheckable(boolean checkable) {
      setBooleanProperty(BOOLEAN_PROPERTY_CHECKABLE, checkable);
  }
```

</p>
</details>

<details><summary>setEnabled</summary>
<p>

https://github.com/aosp-mirror/platform_frameworks_base/blob/19e53cfdc8a5c6ef45c0adf2dd239576ddce5822/core/java/android/view/accessibility/AccessibilityNodeInfo.java#L2227

```java
    /**
     * Sets whether this node is enabled.
     * <p>
     *   <strong>Note:</strong> Cannot be called from an
     *   {@link android.accessibilityservice.AccessibilityService}.
     *   This class is made immutable before being delivered to an AccessibilityService.
     * </p>
     *
     * @param enabled True if the node is enabled.
     *
     * @throws IllegalStateException If called from an AccessibilityService.
     */
    public void setEnabled(boolean enabled) {
        setBooleanProperty(BOOLEAN_PROPERTY_ENABLED, enabled);
    }
```

</p>
</details>

The implementation of `hasStateDescription` is still valid

…ent)

This example feels a bit odd to me. The state itself is not concatenated into the announcement, which makes sense, as it would lead to potentially announcing conflicting state if two child elements had separate states like "checked" and "unchecked", but because of this I'm not sure what value this example is providing. If there was no state here and just the label it would work the exact same way.
I think we can probably just remove this one and maybe replace it with one where the parent element has a state and making sure that state is reflected even when the children are combined into it.
facebook#33690 (comment)
facebook#33690 (comment)

I don't think importantForAccessibility="yes" is necessary for any of these examples, so lets remove it on all of them just to make it clear that this isn't a prequalification for this feature working.
facebook#33690 (comment)

Remove duplicate example (this is the same as the previous one)
facebook#33690 (comment)