-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Main][Windows] Working around Long paths limitation on Windows #33707
Conversation
…file paths and command lengths of ndk build commands Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
LogError: RequestError [HttpError]: Must have admin rights to Repository.
at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
status: 403,
response: {
url: 'https://api.github.com/repos/facebook/react-native/issues/33707/labels',
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Thu, 05 May 2022 20:27:20 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-oauth-scopes': '',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'D12E:7937:684F0C:BFCC13:62743328',
'x-oauth-scopes': 'public_repo',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4992',
'x-ratelimit-reset': '1651786039',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '8',
'x-xss-protection': '0'
},
data: {
message: 'Must have admin rights to Repository.',
documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/facebook/react-native/issues/33707/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit.js/16.43.2 Node.js/14.18.1 (Linux 5.13; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["Pick Request"]}',
request: { hook: [Function: bound bound register] }
}
}
danger-results://tmp/danger-results.json |
@cortinico @kelset This change is extending the PR by @alespergl to use relative paths in ndk builds .. |
Base commit: 870755f |
Base commit: 870755f |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test this and verify that it works correctly @mganandraj 👍 Thanks for sending it over.
Sorry it took so long but I had some problems with my Win machine.
I've left one comments that needs to be addressed here.
Moreover, we'll have to:
- Backport this to
main
- Release a new version of
react-native-codegen
from the release branch that contains your fixes.
@kelset for the second point, let's sync on how we're going to do this.
Co-authored-by: Aleš Pergl <alespergl@users.noreply.github.com>
Summary: Cherry picking #33707 to main branch This change is extending the changes made by alespergl to reduce the file paths and command lengths of ndk build commands Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules. We are also reverting the ndk bump as ndk23 is crashing frequently when building RN with new arch. The reduced file paths lengths ensures the ndk bump is not required for relatively short application paths. Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources ## Changelog Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources [CATEGORY] [TYPE] - Message Pull Request resolved: #33784 Test Plan: Verified building on windows box Reviewed By: javache Differential Revision: D36241928 Pulled By: cortinico fbshipit-source-id: 1ce428a271724cbd3b00a24fe03e7d69253f169b
Co-authored-by: Aleš Pergl <alespergl@users.noreply.github.com> Co-authored-by: Ales Pergl <alpergl@microsoft.com>
This change is extending the changes made by alespergl to reduce the file paths and command lengths of ndk build commands
Essentially we are shortening the length of the source files by using relative paths instead of absolute paths as enumerated by the wildcard expression
This commit is extending the fix by including all the new modules introduced into RN for the new architecture, including the generated modules.
We are also reverting the ndk bump as ndk23 is crashing frequently when building RN with new arch. The reduced file paths lengths ensures the ndk bump is not required for relatively short application paths.
Summary
Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources
Changelog
Fix building RN with new architecture on Windows boxes by using relative paths for C++ sources
-->
[CATEGORY] [TYPE] - Message
Test Plan
Verified building and running RNTester.