-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Changelog for 0.69.0 #33730
Prepare Changelog for 0.69.0 #33730
Conversation
Base commit: ea29ae1 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
877bd22
to
fe94545
Compare
Base commit: ea29ae1 |
6814d20
to
405d096
Compare
405d096
to
f5cd6b6
Compare
This changelog is now ready from my side. I have split the commits into individual categories if you want to read through the changes I have made. The initial commit includes whatever the Feel free to add additional reviewers that you think should have a look at this. As a side note, I have noticed some commits like this having two logs:
The We either might want to do a better job at linting the changelog messages in the PR process if we don't to allow these cases or update the changelog generator to generate the messages properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on the changelog formatting so far! 👍
I have left a few suggestions, do not marked all lines which need to be updated, but hope you get the gist of it. 🙂
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Thanks @Simek for the thorough review! I will give this another pass now that I have a better idea what to look for. |
6d9daee
to
3421fd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me 👍 I'm importing this now, but we can keep on iterating on it for a bit
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
CHANGELOG.md
Outdated
|
||
### Breaking | ||
|
||
- Remove console.disableYellowBox support ([b633cc1305](https://github.com/facebook/react-native/commit/b633cc130533f0731b2577123282c4530e4f0abe) by [@GijsWeterings](https://github.com/GijsWeterings)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this match what we wrote on the blogpost, so having 4 bullet points?
- Support for console.disableYellowBox has been dropped
- Already deprecated prop types have been removed (cdfddb4dad, 3e229f27bc, 10199b1581)
- removeListener, deprecated since RN0.xx, was removed from Appearance
- If you were using SegmentedComponentIOS, you will now need to move to the segmented-control library (235f168574)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those logs are in the Removed
section. As @Simek has pointed out when discussing privately, having both
Breaking
and Removed
sections rarely makes sense and is confusing. I can move those points here to match the blog post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think consistency with the blogpost has an higher priority 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👌
Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kelset @fortmarek I've merged this. If there are modifications to do, please let me know 👌 |
This pull request was successfully merged by @fortmarek in d27c8cf. When will my fix make it into a release? | Upcoming Releases |
Summary
Changelog
[Internal] - Changelog for 0.69.0
Test Plan