Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NativeRunnable with fbjni implementation #33776

Closed
wants to merge 2 commits into from
Closed

Replace NativeRunnable with fbjni implementation #33776

wants to merge 2 commits into from

Conversation

javache
Copy link
Member

@javache javache commented May 6, 2022

Summary:
The implementations of these modules is pretty much identical, and we're already shipping the fbjni version of this anyway.

Changelog: [Internal]

Differential Revision: D36200330

@javache @facebook-github-bot
Name Fabric background thread
7dbcb4b 
Differential Revision: D36200090

fbshipit-source-id: afd8c44ad4079996342145cd90d01ebfd0741db5
@javache @facebook-github-bot
Replace NativeRunnable with fbjni implementation
681a8e9 
Summary:
The implementations of these modules is pretty much identical, and we're already shipping the fbjni version of this anyway.

Changelog: [Internal]

Differential Revision: D36200330

fbshipit-source-id: 777e4e3e64288bcc128723939f36f997be7aecba
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 6, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36200330

@analysis-bot
Copy link

analysis-bot commented May 6, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,771,729 -992
android hermes armeabi-v7a 7,177,283 -651
android hermes x86 8,080,619 -876
android hermes x86_64 8,060,547 -1,222
android jsc arm64-v8a 9,644,575 -997
android jsc armeabi-v7a 8,418,922 -639
android jsc x86 9,594,066 -874
android jsc x86_64 10,191,174 -1,232

Base commit: 09878c8
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @javache in 80f7367.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 9, 2022
@javache javache deleted the export-D36200330 branch May 10, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javache @facebook-github-bot @analysis-bot @react-native-bot