-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pod install --project-directory=ios
failing when Hermes is enabled
#33909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Microsoft
Partner: Microsoft
Partner
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
labels
May 25, 2022
hramos
approved these changes
May 26, 2022
@hramos has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @tido64 in eb7cc85. When will my fix make it into a release? | Upcoming Releases |
fortmarek
pushed a commit
that referenced
this pull request
May 30, 2022
…led (#33909) Summary: `pod install --project-directory=ios` silently fails to prep Hermes: ``` % pod install --project-directory=ios [Codegen] Generating ios/build/generated/ios/React-Codegen.podspec.json [Hermes] Downloading Hermes source code for commit 515e112edc267ad58d3c70991b3d9a721cc66b19 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 9478k 0 9478k 0 0 3939k 0 --:--:-- 0:00:02 --:--:-- 5591k [Hermes] Expanding Hermes tarball for commit 515e112edc267ad58d3c70991b3d9a721cc66b19 [Hermes] Using pre-built HermesC [!] One or more resources were not found and will not be included in the project. If they are found later and you want to include them, run `pod install` again. warn Multiple Podfiles were found: ios/Podfile,macos/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md Auto-linking React Native module for target `ReactTestApp`: ReactTestApp-DevSupport Analyzing dependencies Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec` [Codegen] Found FBReactNativeSpec Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec` Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec` Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec` [!] No podspec found for `hermes-engine` in `../node_modules/react-native/sdks/hermes/hermes-engine.podspec` % ls -l node_modules/react-native/sdks total 0 hermes-engine hermesc ``` [iOS] [Fixed] - `pod install --project-directory=ios` fails when Hermes is enabled Pull Request resolved: #33909 Test Plan: Instead of running `pod install` inside `ios` folder, run `pod install --project-directory=ios`. Reviewed By: cortinico Differential Revision: D36693625 Pulled By: hramos fbshipit-source-id: 8757a9c388348276b07c785c211979ec8f2e2f84
34 tasks
facebook-github-bot
referenced
this pull request
Jun 26, 2023
Summary: Exercise `pod install --project-directory=ios` when building the generated iOS project to make sure we don't regress in the future. See also #37992, #35754, #34215, https://github.com/facebook/react-native/issues/33909… ## Changelog: [INTERNAL] [ADDED] - Exercise `pod install --project-directory=ios` when testing the iOS template Pull Request resolved: #37996 Test Plan: CI should pass. Reviewed By: dmytrorykun Differential Revision: D46972815 Pulled By: cipolleschi fbshipit-source-id: 69617b09ac599eba3dde3ddddcf08db95bfc4da3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Merged
This PR has been merged.
p: Microsoft
Partner: Microsoft
Partner
Platform: iOS
iOS applications.
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pod install --project-directory=ios
silently fails to prep Hermes:Changelog
[iOS] [Fixed] -
pod install --project-directory=ios
fails when Hermes is enabledTest Plan
Instead of running
pod install
insideios
folder, runpod install --project-directory=ios
.