Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes: Use pre-built Hermes runtime in iOS Template tests #33974

Closed
wants to merge 2 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Jun 7, 2022

Summary:
Enable Hermes in iOS Template tests and use pre-built Hermes binaries from Circle CI.

Changelog: [Internal]

Differential Revision: D36989241

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 7, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36989241

@analysis-bot
Copy link

analysis-bot commented Jun 7, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,782,640 +0
android hermes armeabi-v7a 7,172,350 +0
android hermes x86 8,093,283 +0
android hermes x86_64 8,069,317 +0
android jsc arm64-v8a 9,649,489 +0
android jsc armeabi-v7a 8,408,181 +0
android jsc x86 9,600,998 +0
android jsc x86_64 10,194,061 +0

Base commit: 68e4e91
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36989241

hramos added a commit to hramos/react-native that referenced this pull request Jun 7, 2022
…33974)

Summary:
Pull Request resolved: facebook#33974

Enable Hermes in iOS Template tests and use pre-built Hermes binaries from Circle CI.

Changelog: [Internal]

Differential Revision: D36989241

fbshipit-source-id: 2593545b2baa99e40b24a682f09d7439853f385f
@analysis-bot
Copy link

analysis-bot commented Jun 8, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 68e4e91
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36989241

hramos added a commit to hramos/react-native that referenced this pull request Jun 9, 2022
…33974)

Summary:
Pull Request resolved: facebook#33974

Enable Hermes in iOS Template tests and use pre-built Hermes binaries from Circle CI.

Changelog: [Internal]

Reviewed By: cortinico, cipolleschi

Differential Revision: D36989241

fbshipit-source-id: 1508114dc7c4c1768b8d74f20e92f0d8fa70c7bc
Differential Revision: D36985477

fbshipit-source-id: f8674c4485184284129e18bd31bea37c6a30ab6b
…33974)

Summary:
Pull Request resolved: facebook#33974

Enable Hermes in iOS Template tests and use pre-built Hermes binaries from Circle CI.

Changelog: [Internal]

Reviewed By: cortinico, cipolleschi

Differential Revision: D36989241

fbshipit-source-id: f3e5b643b41a2bbe7335285e9fd3751538d015ca
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D36989241

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @hramos in d592bdc.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants