Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent from publishing dimensions change event when app changes state #34014

Closed
wants to merge 16 commits into from
Closed

prevent from publishing dimensions change event when app changes state #34014

wants to merge 16 commits into from

Commits on May 24, 2022

  1. fix useWindowDimensions, prevent from publishing dimensions change ev… 

    …ent when it doesn't apply
    @lbaldy
    lbaldy committed May 24, 2022
    Configuration menu
    Copy the full SHA
    8653851 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. update code structure and add comments

    @lbaldy
    lbaldy committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    b0c3bc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. improve comments 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @lbaldy @parasharrajat
    lbaldy and parasharrajat authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    e21080d View commit details
    Browse the repository at this point in the history

  2. simplify comments 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @lbaldy @parasharrajat
    lbaldy and parasharrajat authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    b4b38d2 View commit details
    Browse the repository at this point in the history

  3. update comments

    @lbaldy
    lbaldy authored Jun 7, 2022
    Configuration menu
    Copy the full SHA
    818a073 View commit details
    Browse the repository at this point in the history

  4. shorten the condition, rename the variable to give it more meaningful… 

    … name, add more comments describing it
    @lbaldy
    lbaldy committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    27e65a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Merge pull request Expensify#11 from lbaldy/bugfix/issue-2727 

    prevent from publishing dimensions change event when app changes state
    @iwiznia
    iwiznia authored Jun 9, 2022
    Configuration menu
    Copy the full SHA
    f690dc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Merge branch 'facebook:main' into master

    @roryabraham
    roryabraham authored Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0bee080 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. improve code style 

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    @lbaldy @cipolleschi
    lbaldy and cipolleschi authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    e5856b0 View commit details
    Browse the repository at this point in the history

  2. improve code style 

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    @lbaldy @cipolleschi
    lbaldy and cipolleschi authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    320cb11 View commit details
    Browse the repository at this point in the history

  3. refactor based on PR review comments facebook#34014 (comment) and fac… 

    …ebook#34014 (comment)
    @lbaldy
    lbaldy committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    9d2be30 View commit details
    Browse the repository at this point in the history

  4. code style fixes

    @lbaldy
    lbaldy committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    cabdc03 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. add new line at the end of file for the linter

    @lbaldy
    lbaldy committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    394fd10 View commit details
    Browse the repository at this point in the history

  2. formatting 

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    @lbaldy @cipolleschi
    lbaldy and cipolleschi authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    23f6564 View commit details
    Browse the repository at this point in the history

  3. formatting 

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    @lbaldy @cipolleschi
    lbaldy and cipolleschi authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ff62965 View commit details
    Browse the repository at this point in the history

  4. remove ununsed variable

    @lbaldy
    lbaldy committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    575f054 View commit details
    Browse the repository at this point in the history