Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md, replace wiki links #34035

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jun 21, 2022

Summary

This PR is a follow up for the contributing content move on the website:

It replaces most of the CONTRIBUTING file content with a reference to the contributing overview page on the website, which has been based off the content of this file.

Additionally I have searched thought the code for the wiki links and replaces theme with the correct website links. There was an instance where comment was referring to an old and removed a while ago wiki page, so I just get rid of this link.

Changelog

[Internal] [Chore] - Update CONTRIBUTING.md, replace wiki links

Test Plan

N/A

@Simek Simek requested a review from hramos as a code owner June 21, 2022 09:23
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 21, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,823,968 +536
android hermes armeabi-v7a 7,210,836 +122
android hermes x86 8,134,534 +414
android hermes x86_64 8,114,765 +542
android jsc arm64-v8a 9,690,595 -141
android jsc armeabi-v7a 8,446,696 -137
android jsc x86 9,641,991 -136
android jsc x86_64 10,239,160 -134

Base commit: 79baca6
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Simek in 1999191.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 22, 2022
@Simek Simek deleted the simek/update-contributing-replace-wiki-references branch June 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants