Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Android.mk file in the App Template #34080

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary

I'm simplifying the Android.mk file inside the template as it was confusing. There are two ways to include the generated code from the codegen:

  1. Importing the generated Android.mk file
  2. Include the generate source files in the _appmodules source files.

Those two approaches are mutually exclusive (as doing both will lead to duplicate symbols). Our template comments were confusing and were suggesting a combination of both.

I'm simplifying the comments here by removing the one suggesting to go with option 1 instead.

Changelog

[Android][Changed] - Simplify the Android.mk file in the App Template

Test Plan

Nothing to test here as it's a comments only change

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 27, 2022
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jun 27, 2022
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in 7fb0bb4.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 28, 2022
@cortinico cortinico deleted the nc/simplify-android-mk branch June 29, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants