Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some of the dependencies inside ReactAndroid #34191

Closed
wants to merge 3 commits into from

Conversation

cortinico
Copy link
Contributor

Summary

This cleans up a bit our dependency list inside ReactAndroid. I've re-sorted the lists, and exported everything I could in the gradle.properties.

I wish we could move to the Gradle Version Catalog for Android, but that's not possible at the moment (it will make impossible for users to build from source).

Changelog

[Internal] - Cleanup some of the dependencies inside ReactAndroid

Test Plan

Will rely on a Green CircleCI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 13, 2022
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,819,236 -1,002
android hermes armeabi-v7a 7,212,302 -1,067
android hermes x86 8,131,596 -1,202
android hermes x86_64 8,109,717 -1,115
android jsc arm64-v8a 9,698,027 -531
android jsc armeabi-v7a 8,453,093 -601
android jsc x86 9,648,628 -732
android jsc x86_64 10,246,566 -644

Base commit: 753038c
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 753038c
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in d2bc024.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 14, 2022
@cortinico cortinico deleted the nc/cleanup-reactandroid-deps branch August 4, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants