Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: using AccessibilityNodeInfo#addAction to announce Expandable/Collapsible State #34353

Closed
wants to merge 25 commits into from
Closed

Android: using AccessibilityNodeInfo#addAction to announce Expandable/Collapsible State #34353

wants to merge 25 commits into from

Commits on Aug 5, 2022

  1. draft solution with example

    @fabOnReact
    fabOnReact committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d1b97ec View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. adding examples from snack 

    https://snack.expo.dev/@fabrizio.bertoglio/crabby-graham-crackers
    @fabOnReact
    fabOnReact committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    1b2a898 View commit details
    Browse the repository at this point in the history

  2. adding action expand and collapse

    @fabOnReact
    fabOnReact committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    d58a2db View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    4e5773c View commit details
    Browse the repository at this point in the history

  2. remove useless if statement

    @fabOnReact
    fabOnReact committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    01b0f6c View commit details
    Browse the repository at this point in the history

  3. remove example

    @fabOnReact
    fabOnReact committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9fe1630 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0839607 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    14509d9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e5b6b07 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. remove default expand/collapse action, the state is managed with java… 

    …script callback onAccessibilityAction
    @fabOnReact
    fabOnReact committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    28e9c3b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2e707f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2b18135 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    7033471 View commit details
    Browse the repository at this point in the history

  2. invert ACTION_EXPAND and ACTION_EXPAND (codereview) 

    It should do the opposite, when a state is "expanded" the only available action should be "ACTION_COLLAPSE" and when a state is "collapsed" the only available action should be "ACTION_EXPAND".
facebook#34353 (comment)
    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    f9b710d View commit details
    Browse the repository at this point in the history

  3. commiting example

    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    8e7168f View commit details
    Browse the repository at this point in the history

  4. adding return type to Component

    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    6f4184f View commit details
    Browse the repository at this point in the history

  5. improving example

    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    266f13b View commit details
    Browse the repository at this point in the history

  6. change Expand/Collapse with standard action 

    allows user to change expand/collapse using the default action available
in the accessibility menu
    @fabOnReact
    fabOnReact committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ef30488 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. adding expand/collapse custom actions

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    1160c32 View commit details
    Browse the repository at this point in the history

  2. removing expand/collapse actions

    @fabOnReact
    fabOnReact committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9a60946 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Merge branch 'main' into expanded-state

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    125cb45 View commit details
    Browse the repository at this point in the history

  2. paper - expand/collapse using onAccessibilityAction

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    ba171fc View commit details
    Browse the repository at this point in the history

  3. minor change

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c6d19e9 View commit details
    Browse the repository at this point in the history

  4. adding collapse/expand in performAccessibilityAction callback

    @fabOnReact
    fabOnReact committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b80bcb3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. update example

    @fabOnReact
    fabOnReact committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    914c7a5 View commit details
    Browse the repository at this point in the history