-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codegen trying to parse .d.ts
files
#34439
Conversation
Looks like we might have to backport this to 0.68 and 0.69 potentially? What do you think @cortinico? It will require a new release of the codegen tool (for sure we'll need to cherry-pick for 0.70, I'll add it to the road to 0.70) |
Base commit: 4706d13 |
/rebase |
Yes it will require a new release of the codegen, to potentially be backported also. For the future we could think about having a: |
This failed due to permissions, Need to look into it. |
f425851
to
d332183
Compare
Base commit: 4eec473 |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @tido64 in 0f0d520. When will my fix make it into a release? | Upcoming Releases |
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: #34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Summary: With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters `.d.ts` files because specs may appear to be unused. ## Changelog [General] [Fixed] - Codegen should ignore `.d.ts` files Pull Request resolved: facebook#34439 Test Plan: See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in. If you prefer to use your own test app, try adding [react-native-safe-area-context](https://github.com/th3rdwave/react-native-safe-area-context) as a dependency. Reviewed By: cipolleschi Differential Revision: D38826388 Pulled By: cortinico fbshipit-source-id: eb7c9be2d49286bae86b2428862fbf20f6f32ca5
Summary
With react-native 0.70-rc.3 and new arch, codegen may fail if it encounters
.d.ts
files because specs may appear to be unused.Changelog
[General] [Fixed] - Codegen should ignore
.d.ts
filesTest Plan
See repro in microsoft/react-native-test-app#1052. The build will fail without manually patching this in.
If you prefer to use your own test app, try adding react-native-safe-area-context as a dependency.