Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RN CLI to v9.0.0 and Metro to 0.72.1 #34447

Closed
wants to merge 3 commits into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented Aug 18, 2022

Summary

Stable v9 of the CLI, no major changes compared to previous alpha releases.

Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.1

cc @kelset @huntie

Changelog

[General] [Changed] - Upgrade RN CLI to v9.0.0

Test Plan

CI

@thymikee thymikee requested a review from hramos as a code owner August 18, 2022 18:50
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Aug 18, 2022
@github-actions
Copy link

github-actions bot commented Aug 18, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 3876970

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 18, 2022
@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Aug 18, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 50b1270
Branch: main

Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's missing the bump of the Metro deps to 0.72.1 - need to add those before getting this merged

@thymikee
Copy link
Contributor Author

Shall I wait for the Metro team to upgrade it separately and then rebase?

@kelset
Copy link
Contributor

kelset commented Aug 19, 2022

Shall I wait for the Metro team to upgrade it separately and then rebase?

my understanding is that the whole point of them doing a PR to CLI was that then the CLI+Metro bump would always be done together

@robhogan
Copy link
Contributor

it's missing the bump of the Metro deps to 0.72.1 - need to add those before getting this merged

Yep - sorry for the confusion, I missed some of this discussion yesterday. This is correct.

@thymikee happy to make that update to this PR myself if you don't have chance today

@thymikee
Copy link
Contributor Author

@robhogan I'd appreciate that, thanks!

@facebook-github-bot
Copy link
Contributor

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@robhogan robhogan changed the title Upgrade RN CLI to v9.0.0 Upgrade RN CLI to v9.0.0 and Metro to 0.72.1 Aug 19, 2022
@robhogan robhogan requested a review from kelset August 19, 2022 14:48
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @thymikee in 0c2fe96.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 19, 2022
kelset pushed a commit that referenced this pull request Aug 22, 2022
Summary:
Stable v9 of the CLI, no major changes compared to previous alpha releases.

Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.1

cc kelset huntie

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Changed] - Upgrade RN CLI to v9.0.0, Metro to 0.72.1

Pull Request resolved: #34447

Test Plan: CI

Reviewed By: huntie

Differential Revision: D38838499

Pulled By: robhogan

fbshipit-source-id: 552e2e708270557e2b74c1a3b8d3325774fb0c48

# Conflicts:
#	template/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants