-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RN CLI to v9.0.0 and Metro to 0.72.1 #34447
Conversation
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 50b1270 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's missing the bump of the Metro deps to 0.72.1 - need to add those before getting this merged
Shall I wait for the Metro team to upgrade it separately and then rebase? |
my understanding is that the whole point of them doing a PR to CLI was that then the CLI+Metro bump would always be done together |
Yep - sorry for the confusion, I missed some of this discussion yesterday. This is correct. @thymikee happy to make that update to this PR myself if you don't have chance today |
@robhogan I'd appreciate that, thanks! |
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @thymikee in 0c2fe96. When will my fix make it into a release? | Upcoming Releases |
Summary: Stable v9 of the CLI, no major changes compared to previous alpha releases. Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.1 cc kelset huntie ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Changed] - Upgrade RN CLI to v9.0.0, Metro to 0.72.1 Pull Request resolved: #34447 Test Plan: CI Reviewed By: huntie Differential Revision: D38838499 Pulled By: robhogan fbshipit-source-id: 552e2e708270557e2b74c1a3b8d3325774fb0c48 # Conflicts: # template/package.json
Summary
Stable v9 of the CLI, no major changes compared to previous alpha releases.
Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.1
cc @kelset @huntie
Changelog
[General] [Changed] - Upgrade RN CLI to v9.0.0
Test Plan
CI