Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support Promise.allSettled out of box #34544

Closed
wants to merge 1 commit into from
Closed

Add support Promise.allSettled out of box #34544

wants to merge 1 commit into from

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Aug 31, 2022 •
edited
Loading

Summary

promise diff: 8.0.3...8.2.0
Issue: #30236
Proposal: react-native-community/discussions-and-proposals#491

Changelog

[General] [Added] - Added support Promise.allSettled

Test Plan

Release notes promise@8.2.0

typeof Promise.allSettled // function

@retyui retyui requested a review from hramos as a code owner August 31, 2022 13:18
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
@github-actions
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 38a12b5

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 31, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Aug 31, 2022
@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,634,579 +152
android hermes armeabi-v7a 7,046,705 +145
android hermes x86 7,936,509 +152
android hermes x86_64 7,908,561 +148
android jsc arm64-v8a 9,512,033 +116
android jsc armeabi-v7a 8,287,342 +144
android jsc x86 9,451,580 +132
android jsc x86_64 10,042,826 +130

Base commit: 3d82f7e
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7a6f0e4
Branch: main

@retyui retyui mentioned this pull request Sep 6, 2022
Closed
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Sep 7, 2022
@retyui @facebook-github-bot
Add support Promise.allSettled out of box (#34544)
37338c5 
Summary:
Issue: facebook/react-native#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Sep 7, 2022
@retyui @facebook-github-bot
Add support Promise.allSettled out of box (#34544)
526795a 
Summary:
Issue: facebook/react-native#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @retyui in 951538c.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 7, 2022
@SimenB SimenB mentioned this pull request Sep 8, 2022
Merged
8 tasks
Titozzz pushed a commit that referenced this pull request Sep 26, 2022
@retyui @Titozzz
Add support Promise.allSettled out of box (#34544)
6b55fa8 
Summary:
Issue: #30236

[General] [Added] - Added support `Promise.allSettled`

Pull Request resolved: #34544

Test Plan:
Release notes [`promise@8.2.0`](https://github.com/then/promise/releases/tag/8.2.0)

```tsx
typeof Promise.allSettled // function
```

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
Titozzz pushed a commit that referenced this pull request Oct 10, 2022
@retyui @Titozzz
Add support Promise.allSettled out of box (#34544)
782e0bf 
Summary:
Issue: #30236

[General] [Added] - Added support `Promise.allSettled`

Pull Request resolved: #34544

Test Plan:
Release notes [`promise@8.2.0`](https://github.com/then/promise/releases/tag/8.2.0)

```tsx
typeof Promise.allSettled // function
```

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
@retyui retyui mentioned this pull request Oct 25, 2022
Closed
1 task
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Nov 18, 2022
@avp @facebook-github-bot
Add support Promise.allSettled out of box (#34544)
2396bfc 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 9abdcc8fd3de8c0e68d76df969c73e7e343a996c

Issue: facebook/react-native#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
avp added a commit to avp/hermes that referenced this pull request Nov 22, 2022
@avp
Add support Promise.allSettled out of box (#34544)
7753f73 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 37338c5

Issue: facebook/react-native#30236

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
neildhar pushed a commit to neildhar/hermes that referenced this pull request Nov 22, 2022
@avp @neildhar
Add support Promise.allSettled out of box (#34544)
c872c7e 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 9abdcc8fd3de8c0e68d76df969c73e7e343a996c

Issue: facebook/react-native#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
neildhar pushed a commit to neildhar/hermes that referenced this pull request Nov 23, 2022
@avp @neildhar
Add support Promise.allSettled out of box (#34544)
1350387 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 37338c5

Issue: facebook/react-native#30236

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
neildhar pushed a commit to neildhar/hermes that referenced this pull request Nov 23, 2022
@avp @neildhar
Add support Promise.allSettled out of box (#34544)
b7a2cf2 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 9abdcc8fd3de8c0e68d76df969c73e7e343a996c

Issue: facebook/react-native#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
neildhar pushed a commit to neildhar/hermes that referenced this pull request Nov 23, 2022
@avp @neildhar
Add support Promise.allSettled out of box (#34544)
b9d4831 
Summary:
Original Author: 4661784+retyui@users.noreply.github.com
Original Git: 37338c5

Issue: facebook/react-native#30236

[General] [Added] - Added support `Promise.allSettled`

X-link: facebook/react-native#34544

Original Reviewed By: motiz88

Original Revision: D39170057

Reviewed By: neildhar

Differential Revision: D41240829

fbshipit-source-id: 5cd8113ba99767050d81450de643fc16785527c6
diegolmello pushed a commit to RocketChat/react-native that referenced this pull request Feb 2, 2023
@retyui @diegolmello
Add support Promise.allSettled out of box (facebook#34544)
c0b6670 
Summary:
Issue: facebook#30236

[General] [Added] - Added support `Promise.allSettled`

Pull Request resolved: facebook#34544

Test Plan:
Release notes [`promise@8.2.0`](https://github.com/then/promise/releases/tag/8.2.0)

```tsx
typeof Promise.allSettled // function
```

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@retyui @OlimpiaZurek
Add support Promise.allSettled out of box (facebook#34544)
6b1967c 
Summary:
Issue: facebook#30236

## Changelog

[General] [Added] - Added support `Promise.allSettled`

Pull Request resolved: facebook#34544

Test Plan:
Release notes [`promise@8.2.0`](https://github.com/then/promise/releases/tag/8.2.0)

```tsx
typeof Promise.allSettled // function
```

Reviewed By: motiz88

Differential Revision: D39170057

Pulled By: jacdebug

fbshipit-source-id: 72467285e1ad82510ca8fe3d5f347ec8ae286823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs TypeScript Update Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@retyui @facebook-github-bot @analysis-bot @react-native-bot @jacdebug