Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make style pointerEvents take priority over pointerEvents prop #34597

Closed

Conversation

cyrus25
Copy link
Contributor

@cyrus25 cyrus25 commented Sep 5, 2022

Summary

Make style pointerEvents take priority over pointerEvents prop. Fixes requested changes in #34586

Changelog

[General] [Fixed] - Make style pointerEvents take priority over pointerEvents prop. FIxes requested changes in #34586

Test Plan

Will rely on green cli

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 5, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: a50e6fb
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,637,941 +12
android hermes armeabi-v7a 7,049,931 +3
android hermes x86 7,939,903 +12
android hermes x86_64 7,911,925 +4
android jsc arm64-v8a 9,513,751 +3
android jsc armeabi-v7a 8,289,042 -3
android jsc x86 9,453,286 -1
android jsc x86_64 10,044,536 -2

Base commit: a50e6fb
Branch: main

@necolas
Copy link
Contributor

necolas commented Sep 6, 2022

Can we add test coverage for this? Are there existing unit tests we can expand upon?

@cyrus25
Copy link
Contributor Author

cyrus25 commented Sep 6, 2022

Hi @necolas, I couldn't find any existing unit tests for pointerEvents, although I've added examples for the same.

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cyrus25 in a789ead.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 6, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…ook#34597)

Summary:
Make style pointerEvents take priority over pointerEvents prop. Fixes requested changes in facebook#34586

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[General] [Fixed] - Make style pointerEvents take priority over pointerEvents prop. FIxes requested changes in facebook#34586

Pull Request resolved: facebook#34597

Test Plan: Will rely on green cli

Reviewed By: NickGerleman

Differential Revision: D39269306

Pulled By: cipolleschi

fbshipit-source-id: 0927bf6ad7e3ac63e82dbd1a873532152f29001d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants