Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in ReactCommon/buffer/map.h #34631

Closed
wants to merge 1 commit into from
Closed

Fixed typo in ReactCommon/buffer/map.h #34631

wants to merge 1 commit into from

Conversation

Kwasow
Copy link
Contributor

@Kwasow Kwasow commented Sep 8, 2022

Summary

Fixed a typo inside ReactCommon.

Changelog

[General] [Fixed] - Fixed typo in comment

Test Plan

This change does not require testing.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 8, 2022
@cipolleschi cipolleschi closed this Sep 8, 2022
@cipolleschi cipolleschi reopened this Sep 8, 2022
@analysis-bot
Copy link

analysis-bot commented Sep 8, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,096,963 +0
android hermes armeabi-v7a 6,466,006 +0
android hermes x86 7,515,055 +0
android hermes x86_64 7,373,440 +0
android jsc arm64-v8a 8,962,052 +0
android jsc armeabi-v7a 7,693,675 +0
android jsc x86 9,024,635 +0
android jsc x86_64 9,502,137 +0

Base commit: fc13f4b
Branch: main

@analysis-bot
Copy link

analysis-bot commented Sep 8, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: fc13f4b
Branch: main

@facebook-github-bot
Copy link
Contributor

@rubennorte has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

/rebase

@cortinico
Copy link
Contributor

/rebase

@cipolleschi this failed as the users is too far behind

@cipolleschi
Copy link
Contributor

@Kwasow could you manually rebase, please? 🙏

@Kwasow
Copy link
Contributor Author

Kwasow commented Nov 29, 2022

@cipolleschi I merged the changes from main into my branch

@cipolleschi
Copy link
Contributor

@Kwasow, could you also log into app.circleci.com to renew the GitHub token that CircleCI has? Otherwise the CI pipelines won't run... :(

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Kwasow
Copy link
Contributor Author

Kwasow commented Nov 30, 2022

@cipolleschi I signed back in to CircleCI but am unable to re-run the workflow. Is it something you have to trigger on your end?

@cipolleschi
Copy link
Contributor

/rebase

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pull-bot
Copy link

PR build artifact for a6a96c6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for a6a96c6 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Kwasow in 2db26c5.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 30, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Fixed a typo inside ReactCommon.

## Changelog

[General] [Fixed] - Fixed typo in comment

Pull Request resolved: facebook#34631

Test Plan: _This change does not require testing._

Reviewed By: cortinico

Differential Revision: D39382191

Pulled By: cipolleschi

fbshipit-source-id: 73939daaaa6199992019e74fe67d638176c8b58d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants