Use debug/release tarballs in hermes-engine Pod #34761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D39326467 fbshipit-source-id: aeb7b01ee7a227b807519ed0b0ff744d724b2a14
Differential Revision: D39699165 fbshipit-source-id: e667ec8ee8dd604090fed90ad430d03ad63e64d4
Summary: Separate debug and release tarballs are built in CI. Use the appropriate Hermes artifacts tarball when building hermes-engine. Changelog: [iOS] [Changed] - Remove debugger from Hermes when building for release Differential Revision: D39698499 fbshipit-source-id: 765b73dd0a733e15cee52ae007036be4572b4225
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39698499 |
Base commit: 41c6c69 |
Base commit: 41c6c69 |
|
This pull request was successfully merged by @hramos in 2fc44ac. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34761 Separate debug and release tarballs are built in CI. Use the appropriate Hermes artifacts tarball when building hermes-engine. Add hermes.rb tests. Changelog: [iOS] [Changed] - Remove debugger from Hermes when building for release Reviewed By: cipolleschi Differential Revision: D39698499 fbshipit-source-id: e6b10d34c7f94c2f86fc47d8b97466011aaa75cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Separate debug and release tarballs are built in CI. Use the appropriate Hermes artifacts tarball when building hermes-engine.
Changelog:
[iOS] [Changed] - Remove debugger from Hermes when building for release
Differential Revision: D39698499