Log a SoftException on SurfaceMountingManager.addRootView #34785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
psionic12
referenced
this pull request
Sep 26, 2022
…ad of crashing the app in hybrid apps. (#33133) Summary: As per commit: 4f3b174 which states that "React Native requires that the RootView id be managed entirely by React Native, and will crash in addRootView/startSurface if the native View id isn't set to NO_ID." This behaviour can not be guaranteed in **hybrid** apps that have a native android layer over which ReactRootViews are added and the native views need to have ids on them in order to work. **The control of views can jump back and forth between native android and react-native (fabric). As the ReactRootView is added to ViewGroups (or layouts) in Android Fragments and Activities, they contain ids on their views which might get passed down to the reactRootView by features like DataBinding** Hence this can cause unnecessary crashes at runtime for hybrid apps even when they are not changing the id of the reactRootView object they are adding to their ViewGroups. Our app is a hybrid app that uses both native android and react-native on different screens and on one such screen that has a Fragment adding a ReactRootView to its FrameLayout to render native android views to render in ReactNative, this crash occurs on pressing the back button as well as on unlocking the screen while staying on the same screen. The app was running fine on more than a 100 million devices on React Native 0.63.4 but after updating to 0.67.2, that features this commit, it crashes on the very first device it was tested on. Refer to the issue: #33121 for more information on the crash The fragment in which this issues arises is like this: ```binding.frameLayout.addView(getReactRootView())``` where getReactRootView() is like this: ``` private var mReactRootView: ReactRootView? = null private var mReactInstanceManager: ReactInstanceManager? = null mReactRootView = ReactRootView(context) if (activity != null) { val application = activity?.application if (application is MainApplication) { mReactInstanceManager = application.reactInstanceManager } } fun getReactRootView():View?{ return mReactRootView } ``` So converting this to a soft exception such that pure react-native devs can still see the error while hybrid apps continue to run without crashes. ### Snippet of the change: ``` if (getId() != View.NO_ID) { ReactSoftExceptionLogger.logSoftException( TAG, new IllegalViewOperationException( "Trying to attach a ReactRootView with an explicit id already set to [" + getId() + "]. React Native uses the id field to track react tags and will overwrite this" + " field. If that is fine, explicitly overwrite the id field to View.NO_ID.")); } ``` ## Changelog [GENERAL] [ADDED] - A ReactSoftException log instead of a direct exception being thrown: ``` if (getId() != View.NO_ID) { ReactSoftExceptionLogger.logSoftException( TAG, new IllegalViewOperationException( "Trying to attach a ReactRootView with an explicit id already set to [" + getId() + "]. React Native uses the id field to track react tags and will overwrite this" + " field. If that is fine, explicitly overwrite the id field to View.NO_ID.")); } ``` [GENERAL] [REMOVED]- Directly throwing an exception even when the code is not responsible for this issue: ``` if (getId() != View.NO_ID) { throw new IllegalViewOperationException( "Trying to attach a ReactRootView with an explicit id already set to [" + getId() + "]. React Native uses the id field to track react tags and will overwrite this" + " field. If that is fine, explicitly overwrite the id field to View.NO_ID."); } ``` Pull Request resolved: #33133 Test Plan: This crash is hard to reproduce but when it occurs, this is the only way to fix it. If any app used to crash with this exact error, it will no longer crash but show an error log in Logcat for developers to be informed about the issue. Reviewed By: ShikaSD Differential Revision: D34304212 Pulled By: cortinico fbshipit-source-id: f0eaeef2e905a6e0587df088b43cc49cabda397a
cortinico
reviewed
Sep 26, 2022
Comment on lines
240
to
246
| ReactSoftExceptionLogger.logSoftException( | ||
| TAG, | ||
| new IllegalViewOperationException( | ||
| "Trying to attach a ReactRootView with an explicit id already set to [" | ||
| + rootView.getId() | ||
| + "]. React Native uses the id field to track react tags and will overwrite this" | ||
| + " field. If that is fine, explicitly overwrite the id field to View.NO_ID.")); |
There was a problem hiding this comment.
Can we retain the original message?
cortinico
changed the title
Base commit: cc13b02 |
Base commit: cc13b02 |
Can you also specify the correct changelog entry? |
|
@cortinico Done. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
cortinico
removed
the
Stale
|
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
cortinico
removed
the
Stale
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
cortinico
removed
the
Stale
|
@cortinico merged this pull request in 3429dc1. |
|
This pull request was successfully merged by @psionic12 in 3429dc1. When will my fix make it into a release? | How to file a pick request? |
|
Sorry this took so long :( |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 21, 2024
Summary: This test broke after I merged facebook#34785 yesterday. Just fixing it in a similar way as the test above. Changelog: [Internal] [Changed] - Fix broken unableToAddHandledRootView Differential Revision: D58864166
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Summary: Pull Request resolved: #45101 This test broke after I merged #34785 yesterday. Just fixing it in a similar way as the test above. Changelog: [Internal] [Changed] - Fix broken unableToAddHandledRootView Reviewed By: rubennorte, blakef Differential Revision: D58864166 fbshipit-source-id: 4f48dbfd5238a2811564ce02199af7fc284d39b4
thejamesgore
added a commit
to thejamesgore/react-native
that referenced
this pull request
Jun 21, 2024
…cebook#34785)" This reverts commit 3429dc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow the same solution (do not throw a crash when view ID is set already) used in
ReactAndroid/src/main/java/com/facebook/react/ReactRootView.javaforReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.javaChangelog
[Android] [Changed] - Log a SoftException on SurfaceMountingManager.addRootView
Test Plan
None