Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge enablePropIteratorSetter flags into a single one in CoreFeatures #34869

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Oct 5, 2022

Summary:
Changelog: [Internal]

This merges all instances of enablePropIteratorSetter into a single one.

Both AccesibilityProps and BaseTextProps had their own instances if it, which is now redundant.

Reviewed By: cipolleschi

Differential Revision: D40062555

Summary:
Changelog: [Internal]

This merges all instances of `enablePropIteratorSetter` into a single one.

Both `AccesibilityProps` and `BaseTextProps` had their own instances if it, which is now redundant.

Reviewed By: cipolleschi

Differential Revision: D40062555

fbshipit-source-id: 5cda2390ede891c810b09b3f331d80fbd0439e20
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 5, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40062555

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,739,684 +305
android hermes armeabi-v7a 7,142,158 +103
android hermes x86 8,050,327 -137
android hermes x86_64 8,022,161 -165
android jsc arm64-v8a 9,607,802 +310
android jsc armeabi-v7a 8,373,109 +108
android jsc x86 9,555,014 -140
android jsc x86_64 10,147,595 -165

Base commit: b56d709
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b56d709
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Shestopalyuk in aa5d43f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 5, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
facebook#34869)

Summary:
Pull Request resolved: facebook#34869

Changelog: [Internal]

This merges all instances of `enablePropIteratorSetter` into a single one.

Both `AccesibilityProps` and `BaseTextProps` had their own instances if it, which is now redundant.

Reviewed By: cipolleschi

Differential Revision: D40062555

fbshipit-source-id: b6ccf5a9538612dd731a6f9c4eaceeebcb6d95be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants