-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rn config file load codegen #34895
Fix rn config file load codegen #34895
Conversation
Hi @krystofwoldrich! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: c4f9556 |
Base commit: c4f9556 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase |
0eb198a
to
632363f
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Thank you for the review. Can you merge it? |
This pull request was successfully merged by @krystofwoldrich in 74fda10. When will my fix make it into a release? | Upcoming Releases |
Summary: Resolves #34894 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General][Fixed] - Load react-native.config.js from correct path during codegen Pull Request resolved: #34895 Test Plan: Command line output after fix with extra console logs to show the correctness ( hopefully :) ) of the fix. ```bash ~/repos/sentry-react-native � � krystofwoldrich/multipleRNsamples ± �node node_modules/react-native/scripts/generate-artifacts.js --path sample-new-architecture --outputPath codegen [Codegen] Processing react-native core libraries [Codegen] Found react-native [Codegen] >>>>> Searching for codegen-enabled libraries in /Users/krystofwoldrich/repos/sentry-react-native/node_modules [Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js cwd /Users/krystofwoldrich/repos/sentry-react-native rnConfigFilePath sample-new-architecture/react-native.config.js rnConfigFilePath - resolved /Users/krystofwoldrich/repos/sentry-react-native/sample-new-architecture/react-native.config.js [Codegen] Found sentry/react-native [Codegen] >>>>> Searching for codegen-enabled libraries in the app [Codegen] >>>>> Processing FBReactNativeSpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/FBReactNativeSpecrHeknw/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing rncore [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rncorehCjmlJ/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing RNSentrySpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/RNSentrySpectMmDpf/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios >>>>> Creating component provider Generated schema list: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rn-tmp-schema-list.json Generated provider in: codegen/build/generated/ios [Codegen] Done. ``` Reviewed By: rshest Differential Revision: D40177746 Pulled By: rshest fbshipit-source-id: 970f016db26fda003ee3b47d50e80549fdb88415
Summary: Resolves facebook#34894 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General][Fixed] - Load react-native.config.js from correct path during codegen Pull Request resolved: facebook#34895 Test Plan: Command line output after fix with extra console logs to show the correctness ( hopefully :) ) of the fix. ```bash ~/repos/sentry-react-native � � krystofwoldrich/multipleRNsamples ± �node node_modules/react-native/scripts/generate-artifacts.js --path sample-new-architecture --outputPath codegen [Codegen] Processing react-native core libraries [Codegen] Found react-native [Codegen] >>>>> Searching for codegen-enabled libraries in /Users/krystofwoldrich/repos/sentry-react-native/node_modules [Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js cwd /Users/krystofwoldrich/repos/sentry-react-native rnConfigFilePath sample-new-architecture/react-native.config.js rnConfigFilePath - resolved /Users/krystofwoldrich/repos/sentry-react-native/sample-new-architecture/react-native.config.js [Codegen] Found sentry/react-native [Codegen] >>>>> Searching for codegen-enabled libraries in the app [Codegen] >>>>> Processing FBReactNativeSpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/FBReactNativeSpecrHeknw/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing rncore [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rncorehCjmlJ/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing RNSentrySpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/RNSentrySpectMmDpf/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios >>>>> Creating component provider Generated schema list: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rn-tmp-schema-list.json Generated provider in: codegen/build/generated/ios [Codegen] Done. ``` Reviewed By: rshest Differential Revision: D40177746 Pulled By: rshest fbshipit-source-id: 970f016db26fda003ee3b47d50e80549fdb88415
Summary: Resolves facebook#34894 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General][Fixed] - Load react-native.config.js from correct path during codegen Pull Request resolved: facebook#34895 Test Plan: Command line output after fix with extra console logs to show the correctness ( hopefully :) ) of the fix. ```bash ~/repos/sentry-react-native � � krystofwoldrich/multipleRNsamples ± �node node_modules/react-native/scripts/generate-artifacts.js --path sample-new-architecture --outputPath codegen [Codegen] Processing react-native core libraries [Codegen] Found react-native [Codegen] >>>>> Searching for codegen-enabled libraries in /Users/krystofwoldrich/repos/sentry-react-native/node_modules [Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js cwd /Users/krystofwoldrich/repos/sentry-react-native rnConfigFilePath sample-new-architecture/react-native.config.js rnConfigFilePath - resolved /Users/krystofwoldrich/repos/sentry-react-native/sample-new-architecture/react-native.config.js [Codegen] Found sentry/react-native [Codegen] >>>>> Searching for codegen-enabled libraries in the app [Codegen] >>>>> Processing FBReactNativeSpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/FBReactNativeSpecrHeknw/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing rncore [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rncorehCjmlJ/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios [Codegen] >>>>> Processing RNSentrySpec [Codegen] Generated schema: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/RNSentrySpectMmDpf/schema.json [Codegen] Generated artifacts: codegen/build/generated/ios >>>>> Creating component provider Generated schema list: /var/folders/tl/jddrmdy97gj0cljrcwb_qkzc0000gn/T/rn-tmp-schema-list.json Generated provider in: codegen/build/generated/ios [Codegen] Done. ``` Reviewed By: rshest Differential Revision: D40177746 Pulled By: rshest fbshipit-source-id: 970f016db26fda003ee3b47d50e80549fdb88415
Summary
Resolves #34894
Changelog
[General][Fixed] - Load react-native.config.js from correct path during codegen
Test Plan
Command line output after fix with extra console logs to show the correctness ( hopefully :) ) of the fix.