Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward: Filtering platform in codegen #34897

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Oct 7, 2022

Summary:
This commit added the possibility to create a Codegen specs that are platform specific.
However, it also modifies how the codegen is invoked and we need to publish a new version of the react-native-codegen package on NPM before we can use that feature.

Changelog:

[General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen.

Differential Revision: D40176447

Summary:
This [commit](facebook@7680bde) added the possibility to create a Codegen specs that are platform specific.
However, it also modifies how the codegen is invoked and we need to publish a new version of the `react-native-codegen` package on NPM before we can use that feature.

## CHANGELOG
[General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen.

Differential Revision: D40176447

fbshipit-source-id: c1e169e7f128aaf3d009ad8fb78a52718192a94d
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 7, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40176447

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,746,762 +0
android hermes armeabi-v7a 7,148,545 +0
android hermes x86 8,057,738 +0
android hermes x86_64 8,028,677 +0
android jsc arm64-v8a 9,608,172 +0
android jsc armeabi-v7a 8,373,430 +0
android jsc x86 9,555,436 +0
android jsc x86_64 10,147,977 +0

Base commit: 2afcea2
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2afcea2
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in ae3dd54.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 7, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#34897

This [commit](facebook@7680bde) added the possibility to create Codegen specs that are platform specific.
However, it also modifies how the codegen is invoked and we need to publish a new version of the `react-native-codegen` package on NPM before we can use that feature.

## Changelog:
[General][Fixed] - Remove usage of the codegen spec filtering until we publish a new version of the codegen.

Reviewed By: robhogan

Differential Revision: D40176447

fbshipit-source-id: 20be630dec3dcd7efb9fd510c6cf9f2c161f906a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants