-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update info.plist #34919
Update info.plist #34919
Conversation
Change version of rn apps following xcode settings.
can you give for context for why this change is needed? is that how Xcode14 generates new project? is there a changelog that explains why it's needed? |
You will have problem when you release it to appstore. *as we know we need upload to appstore with higher version of apps. so if you do that we need to edit info.plist everytime we want upload to appstore. So with this changes will help changing version on xcode. |
Could you update the changelog properly, please?
Thank you so much! |
Edited sir. Thank you! |
Base commit: 0e2f090 |
Hi @erfinbadrian! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 0e2f090 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @erfinbadrian in dcd2114. When will my fix make it into a release? | Upcoming Releases |
@erfinbadrian how did you test this change? I just tried to create a sample app from main (where your commit has landed) and it breaks with
You can get this result by being on main and running we might have to revert this @cipolleschi |
Summary: Change version of rn apps following xcode settings. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS][Fixed] - Automatically following version on xcode. Pull Request resolved: facebook#34919 Reviewed By: cipolleschi Differential Revision: D40340271 Pulled By: motiz88 fbshipit-source-id: a2263a8c7a70847fe6fcedcd82c5109100aafde6
fixed here: #35012 |
Summary: Recently this PR got merged #34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly: <img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png"> This PR takes care of setting the variable so that the app can build successfully. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS] [Fixed] - add MARKETING_VERSION to template project Pull Request resolved: #35012 Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator. Reviewed By: cipolleschi Differential Revision: D40472420 Pulled By: cortinico fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
Summary: Change version of rn apps following xcode settings. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS][Fixed] - Automatically following version on xcode. Pull Request resolved: facebook#34919 Reviewed By: cipolleschi Differential Revision: D40340271 Pulled By: motiz88 fbshipit-source-id: a2263a8c7a70847fe6fcedcd82c5109100aafde6
…ok#35012) Summary: Recently this PR got merged facebook#34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly: <img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png"> This PR takes care of setting the variable so that the app can build successfully. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS] [Fixed] - add MARKETING_VERSION to template project Pull Request resolved: facebook#35012 Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator. Reviewed By: cipolleschi Differential Revision: D40472420 Pulled By: cortinico fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
Change version of rn apps following xcode settings.
Summary
Changelog
[iOS][Fixed] - Automatically following version on xcode.
Test Plan