Setup publishing for Snapshot and Stable on Maven #34967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D40146212 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D40146212 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: facebook#34967 This diff is a preparatory work for publishing artifacts on Maven Central. What it does is: 1. It sets up all the 3 modules (react-native, hermes-engine, external-artifacts) for publishg 2. Adds coordinates to publish on the Snapshot repository 3. Adds support for appendign -SNAPSHOT version if invoked with `-PisNightly=true` 4. Configures GPG signing of artifacts. I haven't touched the CircleCI and JS code yet. I'll do it in another diff. Changelog: [General] [Changed] - Setup publishing for Snapshot and Stable on Maven Reviewed By: mdvacca, cipolleschi Differential Revision: D40146212 fbshipit-source-id: 2c89eb60e39d2ba0290860a8bf238cf60faccef7
cortinico
force-pushed
the
export-D40146212
branch
from
386889c to
b9b1051
Compare
|
This pull request was exported from Phabricator. Differential Revision: D40146212 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Oct 13, 2022
Summary: Pull Request resolved: facebook#34967 This diff is a preparatory work for publishing artifacts on Maven Central. What it does is: 1. It sets up all the 3 modules (react-native, hermes-engine, external-artifacts) for publishg 2. Adds coordinates to publish on the Snapshot repository 3. Adds support for appendign -SNAPSHOT version if invoked with `-PisNightly=true` 4. Configures GPG signing of artifacts. I haven't touched the CircleCI and JS code yet. I'll do it in another diff. Changelog: [General] [Changed] - Setup publishing for Snapshot and Stable on Maven Reviewed By: mdvacca, cipolleschi Differential Revision: D40146212 fbshipit-source-id: f152eb4cb1b88708d5418a0a6ebab53bb7e3678d
cortinico
force-pushed
the
export-D40146212
branch
from
b9b1051 to
bb22efb
Compare
Summary: Pull Request resolved: facebook#34967 This diff is a preparatory work for publishing artifacts on Maven Central. What it does is: 1. It sets up all the 3 modules (react-native, hermes-engine, external-artifacts) for publishg 2. Adds coordinates to publish on the Snapshot repository 3. Adds support for appendign -SNAPSHOT version if invoked with `-PisNightly=true` 4. Configures GPG signing of artifacts. I haven't touched the CircleCI and JS code yet. I'll do it in another diff. Changelog: [General] [Changed] - Setup publishing for Snapshot and Stable on Maven Reviewed By: mdvacca, cipolleschi Differential Revision: D40146212 fbshipit-source-id: fdd6381896511608e138ac54cd19c7b6cdee8755
|
This pull request was exported from Phabricator. Differential Revision: D40146212 |
cortinico
force-pushed
the
export-D40146212
branch
from
bb22efb to
e57a192
Compare
Base commit: c42d824 |
Base commit: c42d824 |
|
This pull request was successfully merged by @cortinico in 0e2f090. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
Summary: Pull Request resolved: facebook#34967 This diff is a preparatory work for publishing artifacts on Maven Central. What it does is: 1. It sets up all the 3 modules (react-native, hermes-engine, external-artifacts) for publishg 2. Adds coordinates to publish on the Snapshot repository 3. Adds support for appendign -SNAPSHOT version if invoked with `-PisNightly=true` 4. Configures GPG signing of artifacts. I haven't touched the CircleCI and JS code yet. I'll do it in another diff. Changelog: [General] [Changed] - Setup publishing for Snapshot and Stable on Maven Reviewed By: mdvacca, cipolleschi Differential Revision: D40146212 fbshipit-source-id: 9321e16f6c18b35bc3ae785749d613085c56e7bc
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34967 This diff is a preparatory work for publishing artifacts on Maven Central. What it does is: 1. It sets up all the 3 modules (react-native, hermes-engine, external-artifacts) for publishg 2. Adds coordinates to publish on the Snapshot repository 3. Adds support for appendign -SNAPSHOT version if invoked with `-PisNightly=true` 4. Configures GPG signing of artifacts. I haven't touched the CircleCI and JS code yet. I'll do it in another diff. Changelog: [General] [Changed] - Setup publishing for Snapshot and Stable on Maven Reviewed By: mdvacca, cipolleschi Differential Revision: D40146212 fbshipit-source-id: 9321e16f6c18b35bc3ae785749d613085c56e7bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a preparatory work for publishing artifacts on Maven Central.
What it does is:
-PisNightly=trueI haven't touched the CircleCI and JS code yet. I'll do it in another diff.
Changelog:
[General] [Changed] - Setup publishing for Snapshot and Stable on Maven
Reviewed By: mdvacca, cipolleschi
Differential Revision: D40146212