Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Promise.any out of box #35080

Closed
wants to merge 1 commit into from
Closed

Conversation

retyui
Copy link
Contributor

@retyui retyui commented Oct 25, 2022

Summary

Changelog

[General] [Added] - Added support Promise.any

Test Plan

Release notes promise@8.3.0

typeof Promise.any // function

@retyui retyui requested a review from hramos as a code owner October 25, 2022 15:17
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2022
@github-actions
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 30022e4

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Oct 25, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,062,261 +178
android hermes armeabi-v7a 6,466,887 +178
android hermes x86 7,376,864 +186
android hermes x86_64 7,345,656 +182
android jsc arm64-v8a 8,919,228 +127
android jsc armeabi-v7a 7,685,718 +132
android jsc x86 8,868,939 +134
android jsc x86_64 9,459,656 +132

Base commit: e9b89b5
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 745f3ee
Branch: main

@pull-bot
Copy link

PR build artifact for 30022e4 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Oct 27, 2022
Summary:
`promise` module diff: [`8.2.0...8.3.0`](https://npmfs.com/compare/promise/8.2.0/8.3.0/)
- Hermes issue: facebook/hermes#766

## Changelog

[General] [Added] - Added support `Promise.any`

X-link: facebook/react-native#35080

Reviewed By: cortinico

Differential Revision: D40681373

Pulled By: jacdebug

fbshipit-source-id: ecd589186483f3aa0f48da28a1f6dfcb1e26c8bc
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @retyui in 475310d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 27, 2022
kelset pushed a commit that referenced this pull request Nov 14, 2022
Summary:
`promise` module diff: [`8.2.0...8.3.0`](https://npmfs.com/compare/promise/8.2.0/8.3.0/)
- Hermes issue: facebook/hermes#766

## Changelog

[General] [Added] - Added support `Promise.any`

Pull Request resolved: #35080

Test Plan:
Release notes [`promise@8.3.0`](https://github.com/then/promise/releases/tag/8.3.0)

```tsx
typeof Promise.any // function
```

Reviewed By: cortinico

Differential Revision: D40681373

Pulled By: jacdebug

fbshipit-source-id: ecd589186483f3aa0f48da28a1f6dfcb1e26c8bc

# Conflicts:
#	package.json
#	yarn.lock
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
`promise` module diff: [`8.2.0...8.3.0`](https://npmfs.com/compare/promise/8.2.0/8.3.0/)
- Hermes issue: facebook/hermes#766

## Changelog

[General] [Added] - Added support `Promise.any`

Pull Request resolved: facebook#35080

Test Plan:
Release notes [`promise@8.3.0`](https://github.com/then/promise/releases/tag/8.3.0)

```tsx
typeof Promise.any // function
```

Reviewed By: cortinico

Differential Revision: D40681373

Pulled By: jacdebug

fbshipit-source-id: ecd589186483f3aa0f48da28a1f6dfcb1e26c8bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants