chore(deps): add wanted dependencies to remove yarn warnings #35122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unused dep Reorder Update packages/react-native-bots/package.json Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com> Update packages/hermes-inspector-msggen/package.json Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com> Revert "remove unused dep" This reverts commit 4dd519550193da8ffda113510903e94b9d73fde0.
facebook-github-bot
added
CLA Signed
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
approved these changes
Oct 28, 2022
cortinico
approved these changes
Oct 28, 2022
Base commit: d0f94e6 |
Base commit: d0f94e6 |
|
This pull request was successfully merged by @kelset in cd25fb3. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#35122) Summary: This is take 2 of this facebook#35088, see this comment for why facebook#35088 (comment) I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install. It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - add wanted dependencies to remove yarn warnings Pull Request resolved: facebook#35122 Test Plan: ### Before <img width="1920" alt="Screenshot 2022-10-26 at 10 53 32" src="https://user-images.githubusercontent.com/16104054/197996489-f463be29-b35b-45cc-9d9c-2d176579fb7d.png"> ### After <img width="947" alt="Screenshot 2022-10-26 at 10 52 19" src="https://user-images.githubusercontent.com/16104054/197996505-3d60b319-006b-45ab-83bf-2f431272fdcd.png"> Reviewed By: cortinico Differential Revision: D40804260 Pulled By: rshest fbshipit-source-id: 86af14c885d6d63a0d60bb85f204d17d8757f72a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is take 2 of this #35088, see this comment for why #35088 (comment)
I wanted to start working on a thing but this barrage of warnings was very annoying so ended up doing this instead: a very small PR to take care of some warnings during yarn install.
It doesn't change anything (the versions are the ones already used all around the repo), just makes yarn happier.
Changelog
[General] [Fixed] - add wanted dependencies to remove yarn warnings
Test Plan
Before
After