-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1/n Adding Android support for Accessibility TtsSpan API - Support for accessibilitySpan and accessibilityLabel props in nested Text #35130
Commits on Oct 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 216a30a - Browse repository at this point
Copy the full SHA 216a30aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a01d0 - Browse repository at this point
Copy the full SHA 48a01d0View commit details
Commits on Oct 31, 2022
-
Notes "The Screenreader stops reading the span text when the focus moves on the AccessibilityLink. The issue may be connected to the latest changes. incompatible types: CharSequence cannot be converted to SpannableString spannableDescription = text.subSequence(start, end); The start and end of the AccessibilityLink need to be updated after changing the length of the string. Complete the functionality and fix all the compile errors" "facebook#35130 (comment) https://github.com/fabriziobertoglio1987/react-native/blob/48a01d006a45c49018d8c3860f40b696b1aa7269/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L600"
Configuration menu - View commit details
-
Copy full SHA for 08d6f43 - Browse repository at this point
Copy the full SHA 08d6f43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 145303e - Browse repository at this point
Copy the full SHA 145303eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f66e914 - Browse repository at this point
Copy the full SHA f66e914View commit details
Commits on Nov 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3d4e662 - Browse repository at this point
Copy the full SHA 3d4e662View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1653d6b - Browse repository at this point
Copy the full SHA 1653d6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6def7a9 - Browse repository at this point
Copy the full SHA 6def7a9View commit details -
Fabric cpp settings trigger runtime error
terminating with uncaught exception of type std::length_error: vector (screenshot1, screenshot2) https://www.icloud.com/iclouddrive/0a4Urx1Av554xzHH1hh3YHy9A#first_screenshot https://stackoverflow.com/a/1183709/7295772
Configuration menu - View commit details
-
Copy full SHA for 7fa58f5 - Browse repository at this point
Copy the full SHA 7fa58f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e7c29 - Browse repository at this point
Copy the full SHA 43e7c29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0afdc69 - Browse repository at this point
Copy the full SHA 0afdc69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cd0ac4 - Browse repository at this point
Copy the full SHA 0cd0ac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5a3b49 - Browse repository at this point
Copy the full SHA f5a3b49View commit details
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 08fc9ac - Browse repository at this point
Copy the full SHA 08fc9acView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2adbb8 - Browse repository at this point
Copy the full SHA c2adbb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c4fb8 - Browse repository at this point
Copy the full SHA 46c4fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45ec47f - Browse repository at this point
Copy the full SHA 45ec47fView commit details
Commits on Nov 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0a00193 - Browse repository at this point
Copy the full SHA 0a00193View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72ee5a1 - Browse repository at this point
Copy the full SHA 72ee5a1View commit details -
accessibilityRole verbatim correctly announces span text, but does no…
…t focus on on nested text
Configuration menu - View commit details
-
Copy full SHA for 81fe302 - Browse repository at this point
Copy the full SHA 81fe302View commit details -
Remove logic for announcing nested text
announcement of TtsSpan works with Text and nested text, but they are not focusable. The functionality will be added as second PR
Configuration menu - View commit details
-
Copy full SHA for 7af9bd3 - Browse repository at this point
Copy the full SHA 7af9bd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16f1f39 - Browse repository at this point
Copy the full SHA 16f1f39View commit details -
Configuration menu - View commit details
-
Copy full SHA for d845073 - Browse repository at this point
Copy the full SHA d845073View commit details -
Configuration menu - View commit details
-
Copy full SHA for e215baa - Browse repository at this point
Copy the full SHA e215baaView commit details
Commits on Nov 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 03a125c - Browse repository at this point
Copy the full SHA 03a125cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe5c480 - Browse repository at this point
Copy the full SHA fe5c480View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e264da - Browse repository at this point
Copy the full SHA 7e264daView commit details -
- add date TtsSpan - remove ids.xml and setTag logic - remove changes to AccessibilityLinks
Configuration menu - View commit details
-
Copy full SHA for d8823e5 - Browse repository at this point
Copy the full SHA d8823e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d4b8a5 - Browse repository at this point
Copy the full SHA 9d4b8a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b85e25 - Browse repository at this point
Copy the full SHA 7b85e25View commit details -
Configuration menu - View commit details
-
Copy full SHA for aefa45f - Browse repository at this point
Copy the full SHA aefa45fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95d6d3b - Browse repository at this point
Copy the full SHA 95d6d3bView commit details
Commits on Nov 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 24c182a - Browse repository at this point
Copy the full SHA 24c182aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4231f - Browse repository at this point
Copy the full SHA 7b4231fView commit details
Commits on Nov 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4fbc54b - Browse repository at this point
Copy the full SHA 4fbc54bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a8104 - Browse repository at this point
Copy the full SHA 29a8104View commit details
Commits on Nov 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e3fd7ff - Browse repository at this point
Copy the full SHA e3fd7ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e1d292 - Browse repository at this point
Copy the full SHA 3e1d292View commit details
Commits on Nov 15, 2022
-
Adding prop accessibilityUnit to TextAttributesProps (fabric) (#3)
## Summary Adds the accessibilityUnit to fabric CPP API (part of PR facebook#35130 Adding support for Android Accessibility TtsSpan API) The TtsSpan API now supports verbatim, date, and fraction but may not work with other span types like phone numbers, currency, time, measure, and money. An explanation of the use case is as follows: - Time is spelled 1 0 3 0 instead of ten thirty - The developer does not have the option to specify if 10m stands for 10 meters or 10 miles, or 10 minutes - Phone numbers, for example, 33312344, are not yet supported Implementing the above functionality requires adding a new prop to the react-native API responsible for managing attributes of nested Text. - Java and CPP TextAttributes manage the functionality. - Nested Text does not correspond to a Widget on Android but an Android TextView Span. The spans are updated based on a caching mechanism that re-renders the Android TextView only if specific attributes are updated. The updates are triggered only if the Text or Paragraph Text attributes change. - An example of Text attributes is accessibilityRole, font-weight, and backgroundColor. - An example of Paragraph attributes is textBreakstrategy. They are updated with different mechanisms because they may change the paragraph layout. These mappings are configured in Java, CPP, and Javascript. As this and PR [facebook#33468](facebook#33468) require changes to the text attributes, the below work was needed: - issue documented in PR [facebook#33468 (comment)](facebook#33468 (comment)) and PR [facebook#35130 (comment)](facebook#35130 (comment)). The CPP changes for facebook#35130 are moved to a separate PR ([fabriziobertoglio1987#2](#2)). The RNTester App would crash without a clear stack trace on startup after making changes to CPP. This was later fixed by adding the CPP headers to the prefab library rrc_view (see this [comment](facebook#35130 (comment))). - Adding the CPP configurations (see [fabriziobertoglio1987#2](https://github.com/fabriziobertoglio1987/react-- native/pull/2)) required extensive troubleshooting and analysis Related: PR #4 - separating accessibilityUnit from accessibilityMinutes and accessibilityHours
Configuration menu - View commit details
-
Copy full SHA for 8b23efd - Browse repository at this point
Copy the full SHA 8b23efdView commit details -
Configuration menu - View commit details
-
Copy full SHA for bea5af9 - Browse repository at this point
Copy the full SHA bea5af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc18d4 - Browse repository at this point
Copy the full SHA 6fc18d4View commit details
Commits on Nov 16, 2022
-
The ReactTtsSpan.Builder constructor expects a string and not an Acce…
…ssibilityRole type in TextLayoutMapManagerBuffer Review logic in [TextLayoutManagerBuffer](https://github.com/facebook/react-native/pull/35130/files#diff-35ab02390dd5f5dffb2c01d532a959c5bebdc9cbf780fbc35f1767120f2330f9R146-R163): The ReactTtsSpan.Builder constructor expects a string and not an AccessibilityRole type in [TextLayoutMapManagerBuffer](https://github.com/fabriziobertoglio1987/react-native/blob/6fc18d45e1df20f39ec07d1527fd42909b8cd82d/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManagerMapBuffer.java#L146) Add a constructor to ReactTtsSpan.Builder that accepts the type AccessibilityRole and converts it to string. Use [getValue()](https://github.com/fabriziobertoglio1987/react-native/blob/6fc18d45e1df20f39ec07d1527fd42909b8cd82d/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java#L152s) to convert. The constructor also accepts the accessibilityUnit parameter and handles those scenarios. Fix build errors from the prev configs Test TtsSpan TIME
Configuration menu - View commit details
-
Copy full SHA for 8b592f7 - Browse repository at this point
Copy the full SHA 8b592f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2642f6 - Browse repository at this point
Copy the full SHA f2642f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4cd23b - Browse repository at this point
Copy the full SHA c4cd23bView commit details
Commits on Nov 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 576bad6 - Browse repository at this point
Copy the full SHA 576bad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 958ae95 - Browse repository at this point
Copy the full SHA 958ae95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a59592 - Browse repository at this point
Copy the full SHA 8a59592View commit details -
static interface method invocations are not supported in -source 7
static interface method invocations are not supported in -source 7 684 Set.of( 685 ^ 686 (use -source 8 or higher to enable static interface method invocations) https://github.com/facebook/react-native/actions/runs/3489954089/jobs/5840743238
Configuration menu - View commit details
-
Copy full SHA for eb95e08 - Browse repository at this point
Copy the full SHA eb95e08View commit details -
error: static interface method invocations are not supported in -sour…
…ce 7 error: static interface method invocations are not supported in -source 7 Set.of( ^ (use -source 8 or higher to enable static interface method invocations) /root/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTtsSpan.java:62: error: static inter
Configuration menu - View commit details
-
Copy full SHA for 5aa9f74 - Browse repository at this point
Copy the full SHA 5aa9f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb52ad9 - Browse repository at this point
Copy the full SHA cb52ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60ef8f0 - Browse repository at this point
Copy the full SHA 60ef8f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06096d5 - Browse repository at this point
Copy the full SHA 06096d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc45e04 - Browse repository at this point
Copy the full SHA cc45e04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 096019c - Browse repository at this point
Copy the full SHA 096019cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f4a0cd - Browse repository at this point
Copy the full SHA 7f4a0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a42fd0 - Browse repository at this point
Copy the full SHA 0a42fd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79c4aed - Browse repository at this point
Copy the full SHA 79c4aedView commit details
Commits on Nov 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dfc4063 - Browse repository at this point
Copy the full SHA dfc4063View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b30659 - Browse repository at this point
Copy the full SHA 3b30659View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe4e1e0 - Browse repository at this point
Copy the full SHA fe4e1e0View commit details
Commits on Dec 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ef9c59b - Browse repository at this point
Copy the full SHA ef9c59bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac79bae - Browse repository at this point
Copy the full SHA ac79baeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 145db13 - Browse repository at this point
Copy the full SHA 145db13View commit details
Commits on Dec 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a892b68 - Browse repository at this point
Copy the full SHA a892b68View commit details
Commits on Jan 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 61e5920 - Browse repository at this point
Copy the full SHA 61e5920View commit details -
Configuration menu - View commit details
-
Copy full SHA for f495025 - Browse repository at this point
Copy the full SHA f495025View commit details -
Configuration menu - View commit details
-
Copy full SHA for 753858e - Browse repository at this point
Copy the full SHA 753858eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 821a4c8 - Browse repository at this point
Copy the full SHA 821a4c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4988339 - Browse repository at this point
Copy the full SHA 4988339View commit details
Commits on Feb 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 02af5a4 - Browse repository at this point
Copy the full SHA 02af5a4View commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dcb9f61 - Browse repository at this point
Copy the full SHA dcb9f61View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7cbd28 - Browse repository at this point
Copy the full SHA e7cbd28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 565d7ed - Browse repository at this point
Copy the full SHA 565d7edView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1c7e0f - Browse repository at this point
Copy the full SHA a1c7e0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f797c20 - Browse repository at this point
Copy the full SHA f797c20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b90011 - Browse repository at this point
Copy the full SHA 8b90011View commit details -
Configuration menu - View commit details
-
Copy full SHA for e830578 - Browse repository at this point
Copy the full SHA e830578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b212e - Browse repository at this point
Copy the full SHA 25b212eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c058657 - Browse repository at this point
Copy the full SHA c058657View commit details
Commits on Feb 6, 2023
-
Verbatim and other strings are not announced.
Cpp is misconfigured and passes allways none to java. As the issue seems caused by the toString conversion, debug the fromRawValue and toString conversions. CPP allways passes “none” for any value. facebook#35130 (comment)
Configuration menu - View commit details
-
Copy full SHA for 151b37c - Browse repository at this point
Copy the full SHA 151b37cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f68513 - Browse repository at this point
Copy the full SHA 6f68513View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1c56ac - Browse repository at this point
Copy the full SHA e1c56acView commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ecc815b - Browse repository at this point
Copy the full SHA ecc815bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c80bdb - Browse repository at this point
Copy the full SHA 7c80bdbView commit details -
Remove not supported TYPES from PR and move them to a separate branch
Configuration menu - View commit details
-
Copy full SHA for 34ed14e - Browse repository at this point
Copy the full SHA 34ed14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23241dd - Browse repository at this point
Copy the full SHA 23241ddView commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 112ed6f - Browse repository at this point
Copy the full SHA 112ed6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 235eda8 - Browse repository at this point
Copy the full SHA 235eda8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d536cf7 - Browse repository at this point
Copy the full SHA d536cf7View commit details
Commits on Feb 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c154196 - Browse repository at this point
Copy the full SHA c154196View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ce49a - Browse repository at this point
Copy the full SHA 76ce49aView commit details