Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Untrack test reports generated by test libraries (reporters) #35187

Closed

Conversation

Pranav-yadav
Copy link
Contributor

Summary

  • Untrack Test Reports generated by test libraries (reporters E.g. jest-junit)
  • E.g. /reports/junit/js-test-results.xml report is generated; when we exec yarn test-ci, which is shouldn't be tracked

NOTE: Used [skip ci] to avoid wastage of compute resources 🤗🌏

  • Feel free to init tests manually if you find it necessary

Changelog

[GENERAL] [CHANGED] - Untrack Test Reports generated by test libraries (reporters E.g. jest-junit)

Test Plan

yarn test-ci
image

- E.g. `/reports/junit/js-test-results.xml` report is generated;
- -when we exec `yarn test-ci`, which is shouldn't be tracked

[skip ci]
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2022
@Pranav-yadav
Copy link
Contributor Author

NOTE: I've used [skip ci] to avoid wastage of compute resources 🤗🌏

Feel free to init tests manually if you find it necessary

@facebook-github-bot
Copy link
Contributor

@sshic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Pranav-yadav

This comment was marked as resolved.

@Pranav-yadav Pranav-yadav changed the title untrack test reports generated by test libraries (reporters) Chore: Untrack test reports generated by test libraries (reporters) Nov 16, 2022
@Pranav-yadav Pranav-yadav deleted the chore/untrack-tests-reports branch November 22, 2022 14:04
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…k#35187)

Summary:
- Untrack Test Reports generated by test libraries (reporters E.g. `jest-junit`)
- E.g. `/reports/junit/js-test-results.xml` report is generated; when we exec `yarn test-ci`, which is **_shouldn't_ be tracked**

### NOTE: Used `[skip ci]` to avoid wastage of compute resources �🌏
- Feel free to init tests manually if you find it necessary

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[GENERAL] [CHANGED] - Untrack Test Reports generated by test libraries (reporters E.g. `jest-junit`)

Pull Request resolved: facebook#35187

Test Plan:
`yarn test-ci`
![image](https://user-images.githubusercontent.com/55224033/199709131-240d844c-a98a-419b-a370-cafe8e927de4.png)

Reviewed By: cipolleschi

Differential Revision: D40993282

Pulled By: sshic

fbshipit-source-id: 3fe150d3e8bd45cec56b50f2dc071002412e475e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants