Revert: make RCTBlobManager TurboModule-compatible #35188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff reverts D40716048 (facebook@279cfec) (facebook#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - facebook#35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ece2b9c653fe01e209a523e6a99e41a0605fddac
facebook-github-bot
added
CLA Signed
cipolleschi
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D40979350 |
Base commit: 890805d |
Base commit: d9ab5e8 |
|
PR build artifact for 94cea1e is ready. |
|
PR build artifact for 94cea1e is ready. |
cipolleschi
approved these changes
Nov 3, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: #35188 This diff reverts D40716048 (279cfec) (#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - #35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ef92cf05636cba818151d4184e0275a3aab56cff
|
This pull request was successfully merged by Dmitry Rykun in bbd432e. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35188 This diff reverts D40716048 (facebook@279cfec) (facebook#35047) which breaks RCTImageLoader. https://pxl.cl/2jKrM Those files are auto-generated and are not supposed to be edited manually. Changelog: [iOS] [Fixed] - facebook#35047 reverted. Reviewed By: cipolleschi Differential Revision: D40979350 fbshipit-source-id: ef92cf05636cba818151d4184e0275a3aab56cff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff reverts D40716048 (279cfec) (#35047) which breaks RCTImageLoader.
https://pxl.cl/2jKrM
Those files are auto-generated and are not supposed to be edited manually.
Changelog: [iOS] [Fixed] - #35047 reverted.
Reviewed By: cipolleschi
Differential Revision: D40979350