Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: mv translateFunctionTypeAnnotation fn > parsers-commons.js #35343

Closed
wants to merge 1 commit into from
Closed

Chore: mv translateFunctionTypeAnnotation fn > parsers-commons.js #35343

wants to merge 1 commit into from

Conversation

Pranav-yadav
Copy link
Contributor

@Pranav-yadav Pranav-yadav commented Nov 14, 2022 •
edited
Loading

Summary

This PR should solve the "Circular Dependencies" problem/issue because of which some PRs are getting blocked as discussed here #35288 (comment)

  • also moved below helpers to parsers-commons.js;
  • getTypeAnnotationParameters
  • getFunctionNameFromParameter
  • getParameterName
  • getParameterTypeAnnotation
  • getTypeAnnotationReturnType

<3

Changelog

[INTERNAL] [CHANGED] - Moved translateFunctionTypeAnnotation fn from parsers-primitives.js to parsers-commons.js also, moved it's helpers

Test Plan

  • ensure 👇 is #00ff00

yarn lint && yarn flow && yarn test-ci

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2022
@Pranav-yadav Pranav-yadav mentioned this pull request Nov 14, 2022
Closed
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Nov 14, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,099,276 +0
android hermes armeabi-v7a 6,468,933 +0
android hermes x86 7,517,132 +0
android hermes x86_64 7,375,791 +0
android jsc arm64-v8a 8,963,923 +0
android jsc armeabi-v7a 7,695,310 +0
android jsc x86 9,026,415 +0
android jsc x86_64 9,504,554 +0

Base commit: 2eccd59
Branch: main

@analysis-bot
Copy link

analysis-bot commented Nov 14, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2eccd59
Branch: main

@pull-bot
Copy link

PR build artifact for f906d91 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for f906d91 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@cipolleschi
Copy link
Contributor

/rebase

@Pranav-yadav @cipolleschi
mv translateFunctionTypeAnnotation fn > parsers-commons.js
c8af053 
- also moved below helpers > `parsers-commons.js`;
- `getTypeAnnotationParameters`
- `getFunctionNameFromParameter`
- `getParameterName`
- `getParameterTypeAnnotation`
- `getTypeAnnotationReturnType`

<3
@github-actions github-actions bot force-pushed the ch/mv-translateFunctionTypeAnnotation branch from f906d91 to c8af053 Compare November 15, 2022 10:04
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pull-bot
Copy link

PR build artifact for c8af053 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@pull-bot
Copy link

PR build artifact for c8af053 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@Pranav-yadav Pranav-yadav deleted the ch/mv-translateFunctionTypeAnnotation branch November 15, 2022 17:45
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@Pranav-yadav @OlimpiaZurek
Chore: mv translateFunctionTypeAnnotation fn > parsers-commons.js (…
ce2dc8f 
…facebook#35343)

Summary:
This PR should solve the `"Circular Dependencies"` problem/issue because of which some PRs are getting blocked as discussed here facebook#35288 (comment)

- also moved below helpers to `parsers-commons.js`;
- `getTypeAnnotationParameters`
- `getFunctionNameFromParameter`
- `getParameterName`
- `getParameterTypeAnnotation`
- `getTypeAnnotationReturnType`

<3

## Changelog

[INTERNAL] [CHANGED] - Moved `translateFunctionTypeAnnotation` fn from `parsers-primitives.js` to `parsers-commons.js` also, moved it's helpers

Pull Request resolved: facebook#35343

Test Plan:
- ensure 👇 is `#00ff00`

`yarn lint && yarn flow && yarn test-ci`

Reviewed By: christophpurrer

Differential Revision: D41273191

Pulled By: rshest

fbshipit-source-id: cc1839a91579e7914f05516a90b280a776510c9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pranav-yadav @facebook-github-bot @analysis-bot @pull-bot @cipolleschi