[LOCAL] Bypass tag check in dry run #35428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
scripts/release-utils.js
Outdated
| @@ -139,7 +139,11 @@ function generateiOSArtifacts( | |||
| return tarballOutputPath; | |||
| } | |||
|
|
|||
| function failIfTagExists(version) { | |||
| function failIfTagExists(version, buildType) { | |||
| if (buildType == 'dry-run') { | |||
There was a problem hiding this comment.
⚠️ scripts/release-utils.js line 143 – Expected '===' and instead saw '=='. (eqeqeq)
|
cipolleschi
force-pushed
the
cipolleschi/bypass-tag-check-in-dry-run
branch
2 times, most recently
from
3771a40
to
ca18fac
Compare
cipolleschi
force-pushed
the
cipolleschi/bypass-tag-check-in-dry-run
branch
from
ca18fac
to
3be3d49
Compare
cipolleschi
changed the title
cipolleschi
pushed a commit
that referenced
this pull request
Nov 25, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
Summary: When dry-run in stable branch, the tag already exists. We are bypassing the tag-existence check when in a dry-run to have the CI pass ## Changelog [General] [Fixed] - Bypass tag version check when dry-run Pull Request resolved: #35470 Test Plan: CircleCI It worked for RC1 and RC2 Reviewed By: cortinico Differential Revision: D41529648 Pulled By: cipolleschi fbshipit-source-id: d4d7f5534f86c2cf10b05e0d4cab950e4902d8df
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: When dry-run in stable branch, the tag already exists. We are bypassing the tag-existence check when in a dry-run to have the CI pass ## Changelog [General] [Fixed] - Bypass tag version check when dry-run Pull Request resolved: facebook#35470 Test Plan: CircleCI It worked for RC1 and RC2 Reviewed By: cortinico Differential Revision: D41529648 Pulled By: cipolleschi fbshipit-source-id: d4d7f5534f86c2cf10b05e0d4cab950e4902d8df
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When dry-run in stable branch, the tag already exists. We are bypassing the tag-existence check when in a dry-run to have the CI pass
Changelog
[General] [Fixed] - Bypass tag version check when dry-run
Test Plan
CircleCI