Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` #35533

dcangulo · 2022-12-02T06:08:56Z

Summary

After adding <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/> on my AndroidManifest.xml, I expected to use PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS but POST_NOTIFICATIONS is undefined and is named POST_NOTIFICATION instead.

Every other Android permission is 1:1 in spelling except this one where it lacks S.

Not sure if this is a welcome change since this can be breaking. Or maybe we can include both with and without S to not be a breaking change. Or just keep it as is and close this PR.

Changelog

[Android] [Changed] - Rename POST_NOTIFICATION to POST_NOTIFICATIONS

Test Plan

PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS should not be undefined.

analysis-bot · 2022-12-02T06:32:37Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,102,159	-35
android	hermes	armeabi-v7a	6,470,950	-27
android	hermes	x86	7,520,368	-33
android	hermes	x86_64	7,378,725	-34
android	jsc	arm64-v8a	8,969,961	+14
android	jsc	armeabi-v7a	7,701,357	+10
android	jsc	x86	9,032,670	+7
android	jsc	x86_64	9,510,150	+5

Base commit: 436da18
Branch: main

analysis-bot · 2022-12-02T07:02:12Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 436da18
Branch: main

pull-bot · 2022-12-02T07:13:46Z

PR build artifact for fd3cf8a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-12-02T07:17:37Z

PR build artifact for fd3cf8a is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

cortinico · 2022-12-02T09:03:56Z

Libraries/PermissionsAndroid/PermissionsAndroid.js

@@ -75,7 +75,7 @@ const PERMISSIONS = Object.freeze({
  ANSWER_PHONE_CALLS: 'android.permission.ANSWER_PHONE_CALLS',
  READ_PHONE_NUMBERS: 'android.permission.READ_PHONE_NUMBERS',
  UWB_RANGING: 'android.permission.UWB_RANGING',
-  POST_NOTIFICATION: 'android.permission.POST_NOTIFICATIONS',
+  POST_NOTIFICATIONS: 'android.permission.POST_NOTIFICATIONS',


Thanks for spotting this. I'm in for a breaking change. The problem is that we shipped this in 0.70 as well, so we'll need to backport this.

Potentially having both is a preferred approach and in 0.72 we can remove the duplicate? (cc @kelset for visiblity)

making sure that I'm following: you want to merge this in main and then cherry pick for both 0.71 and 0.70? I'm ok with that, let's make sure to post comments with links in both release discussions

Asking for your opinion as this is essentially a 'typo' we let pass through. We can add both POST_NOTIFICATION and POST_NOTIFICATIONS in the JS API and have the breaking change in .72 OR have this as a breaking change in both .70 and .71

I'd rather not do breaking changes in 0.70 since it's already out. For 0.71 we are still in time to add as a BC. For 0.72 is no problem.

that said, my personal preference would be no breaking changes in 0.70 and 0.71, but yes for 0.72 - but I'm not sure what that would imply here

Ok so let's merge this and pick it on 0.70/0.71
Then let's do the breaking change on main for 72

pull-bot · 2022-12-02T15:21:59Z

PR build artifact for 28147f8 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot · 2022-12-02T15:25:21Z

PR build artifact for 28147f8 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

dcangulo · 2022-12-02T16:04:09Z

@cortinico Restored to not be a breaking change.

facebook-github-bot · 2022-12-03T01:15:58Z

@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-12-09T20:59:55Z

@philIip merged this pull request in 910a750.

Summary: After adding `<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>` on my `AndroidManifest.xml`, I expected to use `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` but `POST_NOTIFICATIONS` is `undefined` and is named `POST_NOTIFICATION` instead. Every other Android permission is 1:1 in spelling except this one where it lacks `S`. Not sure if this is a welcome change since this can be breaking. Or maybe we can include both with and without `S` to not be a breaking change. Or just keep it as is and close this PR. ## Changelog  [Android] [Changed] - Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` Pull Request resolved: #35533 Test Plan: `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` should not be `undefined`. Reviewed By: cortinico Differential Revision: D41705866 Pulled By: philIip fbshipit-source-id: a0328b174f0196421565f0cd2b2f1eb509428553 # Conflicts: # packages/rn-tester/js/examples/PermissionsAndroid/PermissionsExample.js

Summary: After adding `<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>` on my `AndroidManifest.xml`, I expected to use `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` but `POST_NOTIFICATIONS` is `undefined` and is named `POST_NOTIFICATION` instead. Every other Android permission is 1:1 in spelling except this one where it lacks `S`. Not sure if this is a welcome change since this can be breaking. Or maybe we can include both with and without `S` to not be a breaking change. Or just keep it as is and close this PR. ## Changelog  [Android] [Changed] - Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` Pull Request resolved: #35533 Test Plan: `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` should not be `undefined`. Reviewed By: cortinico Differential Revision: D41705866 Pulled By: philIip fbshipit-source-id: a0328b174f0196421565f0cd2b2f1eb509428553

Summary: After adding `<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>` on my `AndroidManifest.xml`, I expected to use `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` but `POST_NOTIFICATIONS` is `undefined` and is named `POST_NOTIFICATION` instead. Every other Android permission is 1:1 in spelling except this one where it lacks `S`. Not sure if this is a welcome change since this can be breaking. Or maybe we can include both with and without `S` to not be a breaking change. Or just keep it as is and close this PR. ## Changelog  [Android] [Changed] - Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` Pull Request resolved: facebook#35533 Test Plan: `PermissionsAndroid.PERMISSIONS.POST_NOTIFICATIONS` should not be `undefined`. Reviewed By: cortinico Differential Revision: D41705866 Pulled By: philIip fbshipit-source-id: a0328b174f0196421565f0cd2b2f1eb509428553

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2022

react-native-bot added the Platform: Android Android applications. label Dec 2, 2022

cortinico reviewed Dec 2, 2022

View reviewed changes

Rename POST_NOTIFICATION to POST_NOTIFICATIONS

28147f8

dcangulo mentioned this pull request Dec 2, 2022

Rename POST_NOTIFICATION to POST_NOTIFICATIONS facebook/react-native-website#3448

Merged

cortinico approved these changes Dec 5, 2022

View reviewed changes

facebook-github-bot closed this in 910a750 Dec 9, 2022

facebook-github-bot added the Merged This PR has been merged. label Dec 9, 2022

cipolleschi mentioned this pull request Aug 16, 2023

cipolleschi/add maven polling #39039

Merged

cipolleschi mentioned this pull request Sep 21, 2023

[LOCAL] Copy hermes ruby files to hermes folder in local E2E test #39577

Merged

cipolleschi mentioned this pull request Oct 11, 2023

cipolleschi/fix CI #40793

Merged

This was referenced Nov 1, 2023

[RN][CI]Update node installation on debian (0.71) #41277

Merged

[RN][CI]Update node installation on debian (0.70) #41278

Closed

cipolleschi mentioned this pull request Dec 19, 2023

[Local] Bump hermes-engine #41991

Merged

This was referenced Jan 8, 2024

[0.71][RN][General] Migrate boost download url away from JFrog #42177

Merged

[0.70][RN][General] Migrate boost download url away from JFrog #42178

Merged

[RN][iOS] Fix symbol not found _jump_fcontext with use_frameworks! #42229

Merged

cipolleschi mentioned this pull request Mar 6, 2024

[RN][iOS][0.71] Fix flipper for Xcode 15.3 #43345

Merged

cipolleschi mentioned this pull request Apr 5, 2024

cipolleschi/fix yoga archive 0.71 #43895

Closed

cipolleschi mentioned this pull request Apr 26, 2024

[iOS][Privacy Manifest] Set up privacy manifest for React Native 0.71 #44281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` #35533

Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` #35533

dcangulo commented Dec 2, 2022

analysis-bot commented Dec 2, 2022 •

edited

Loading

analysis-bot commented Dec 2, 2022 •

edited

Loading

pull-bot commented Dec 2, 2022

pull-bot commented Dec 2, 2022

cortinico Dec 2, 2022

kelset Dec 2, 2022

cortinico Dec 2, 2022

kelset Dec 2, 2022

kelset Dec 2, 2022 •

edited

Loading

cortinico Dec 2, 2022

pull-bot commented Dec 2, 2022

pull-bot commented Dec 2, 2022

dcangulo commented Dec 2, 2022

facebook-github-bot commented Dec 3, 2022

facebook-github-bot commented Dec 9, 2022

Rename POST_NOTIFICATION to POST_NOTIFICATIONS #35533

Rename POST_NOTIFICATION to POST_NOTIFICATIONS #35533

Conversation

dcangulo commented Dec 2, 2022

Summary

Changelog

Test Plan

analysis-bot commented Dec 2, 2022 • edited Loading

analysis-bot commented Dec 2, 2022 • edited Loading

pull-bot commented Dec 2, 2022

pull-bot commented Dec 2, 2022

cortinico Dec 2, 2022

Choose a reason for hiding this comment

kelset Dec 2, 2022

Choose a reason for hiding this comment

cortinico Dec 2, 2022

Choose a reason for hiding this comment

kelset Dec 2, 2022

Choose a reason for hiding this comment

kelset Dec 2, 2022 • edited Loading

Choose a reason for hiding this comment

cortinico Dec 2, 2022

Choose a reason for hiding this comment

pull-bot commented Dec 2, 2022

pull-bot commented Dec 2, 2022

dcangulo commented Dec 2, 2022

facebook-github-bot commented Dec 3, 2022

facebook-github-bot commented Dec 9, 2022

Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` #35533

Rename `POST_NOTIFICATION` to `POST_NOTIFICATIONS` #35533

analysis-bot commented Dec 2, 2022 •

edited

Loading

analysis-bot commented Dec 2, 2022 •

edited

Loading

kelset Dec 2, 2022 •

edited

Loading