Add jsinspector prefab target #35796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 8bef1b3 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in a80cf96. |
|
thanks @cortinico! |
kelset
pushed a commit
that referenced
this pull request
Jan 19, 2023
Summary: react-native-v8 requires the `jsinspector` for its js inspector feature. this pr adds the `jsinspector` to the prefab target list. ## Changelog [ANDROID][ADDED] - Add `jsinspector` to the prefab target Pull Request resolved: #35796 Test Plan: ``` $ ./gradlew :ReactAndroid:installArchives # check prefab files in aar $ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-release.aar | grep 'prefab\/modules\/jsinspector' $ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-debug.aar | grep 'prefab\/modules\/jsinspector' ``` Reviewed By: cipolleschi Differential Revision: D42430272 Pulled By: cortinico fbshipit-source-id: fd9a02fd9c33cf5d349e1a79da6f78267196efc8
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: react-native-v8 requires the `jsinspector` for its js inspector feature. this pr adds the `jsinspector` to the prefab target list. ## Changelog [ANDROID][ADDED] - Add `jsinspector` to the prefab target Pull Request resolved: facebook#35796 Test Plan: ``` $ ./gradlew :ReactAndroid:installArchives # check prefab files in aar $ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-release.aar | grep 'prefab\/modules\/jsinspector' $ unzip -l android/com/facebook/react/react-android/1000.0.0/react-android-1000.0.0-debug.aar | grep 'prefab\/modules\/jsinspector' ``` Reviewed By: cipolleschi Differential Revision: D42430272 Pulled By: cortinico fbshipit-source-id: fd9a02fd9c33cf5d349e1a79da6f78267196efc8
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-native-v8 requires the
jsinspectorfor its js inspector feature. this pr adds thejsinspectorto the prefab target list.Changelog
[ANDROID][ADDED] - Add
jsinspectorto the prefab targetTest Plan