[Docs] Remove iOS flag from scrollEventThrottle prop #35840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 3c03aef |
|
Thank you @robwalkerco, this has been merged :) |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: The `scrollEventThrottle` prop is documented as only applying to iOS, but in [this commit](facebook@cf55fd5) it was also implemented for Android, but the documentation was not updated. ## Changelog [GENERAL] [CHANGED] - Removed iOS flag from `scrollEventThrottle` docs <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> Pull Request resolved: facebook#35840 Test Plan: I've not been able to find how to build the docs locally, so I don't have a screenshot of the changes :( Reviewed By: cipolleschi Differential Revision: D42530943 Pulled By: sammy-SC fbshipit-source-id: 2948eca2621712ccd832f4f99f1aab0cbd4af2d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
scrollEventThrottleprop is documented as only applying to iOS, but in this commit it was also implemented for Android, but the documentation was not updated.Changelog
[GENERAL] [CHANGED] - Removed iOS flag from
scrollEventThrottledocsTest Plan
I've not been able to find how to build the docs locally, so I don't have a screenshot of the changes :(