Commits on Jan 18, 2023

1. Bump CMake to 3.22.1 to properly honor CMAKE_BUILD_TYPE (facebook#35857) …

   Summary:
   Pull Request resolved: facebook#35857
   
   It seems like there is an incompatibility between NDK 23 (shipped in 0.71)
   and the usage of custom `CMAKE_BUILD_TYPE` we do for Hermes.
   
   Specifically the `-DCMAKE_BUILD_TYPE=Release` we specify for the debug
   variant of Hermes is partially ignored by the new Android native build toolchain.
   See android/ndk#463 for mentions on how the
   toolchains requires CMake 3.20+
   
   As AGP 7.3 defaults to use CMake 3.18 unless specified, and NDK 23 unless specified.
   AGP 7.4 defaults to use CMake 3.22 unless specified, and NDK 23 unless specified.
   See: https://developer.android.com/studio/releases/gradle-plugin#7-4-0
   
   Here I'm:
   1. Bumping the docker image to an image that contains the CMake 3.22
   2. Updating the logic for building `react-native` & `hermes-engine` to use 3.22
   3. Provide fallbacks if the user specified `CMAKE_VERSION`
   
   Template tests will run on AGP 7.3 and will still use CMake 3.18, but I forecast
   no problem there as the user is not supposed to specify custom `CMAKE_BUILD_TYPE`.
   This is only a problem as we build `hermes-engine` with custom build types.
   
   Changelog:
   [Android] [Fixed] - Bump CMake to 3.22.1 to properly honor CMAKE_BUILD_TYPE
   
   Reviewed By: cipolleschi
   
   Differential Revision: D42544864
   
   fbshipit-source-id: d9840b4a14baabf5d20d21d71cc86e2e73a8d0ea

   

   cortinico authored and facebook-github-bot committed Jan 18, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 47082f0
   • Browse repository at this point

   Copy the full SHA

   47082f0 View commit details

   Browse the repository at this point in the history