Commits on Jan 26, 2023

1. Mitigation for Samsung TextInput Hangs (facebook#35967) …

   Summary:
   Pull Request resolved: facebook#35967
   
   In facebook#35936 we observed that the presence of AbsoluteSizeSpan may lead to hangs when using the Grammarly keyboard on Samsung.
   
   This mitigation makes it so that we do not emit this span in any case where it is sufficient to rely on already set EditText textSize. In simple cases, tested on two devices, it causes typing into the TextInput to no longer hang.
   
   This does not fully resolve the issue for TextInputs which meaningfully use layout-effecting spans (or at least font size), such as non-uniform text size within the input. We instead just try to reduce to minimum AbsoluteSizeSpan possible.
   
   Testing the first commit was able to resolve hangs in some simpler inputs tested, by me and cortinico.
   
   Changelog:
   [Android][Fixed] - Mitigation for Samsung TextInput Hangs
   
   Reviewed By: cortinico
   
   Differential Revision: D42721684
   
   fbshipit-source-id: 000a8ceb0200abb19a2aa77cdb78276d289c3115

   

   NickGerleman authored and facebook-github-bot committed Jan 26, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 14adf07
   • Browse repository at this point

   Copy the full SHA

   14adf07 View commit details

   Browse the repository at this point in the history