refactor: Renamed emitPartial to emitObject #35982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42740958 |
Base commit: dc959c9 |
|
This pull request was exported from Phabricator. Differential Revision: D42740958 |
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 27, 2023
Summary: Pull Request resolved: facebook#35982 This reflects better what the former `emitPartial` was doing - emitting an object with set props. ## Changelog: [Internal] [Changed] - Renamed emitPartial to emitObject Reviewed By: christophpurrer Differential Revision: D42740958 fbshipit-source-id: 30ae98edd2a4c9bee856099ef0923e6bd1e8ea6f
vzaidman
force-pushed
the
export-D42740958
branch
from
7b1030e to
e98c507
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42740958 |
vzaidman
force-pushed
the
export-D42740958
branch
from
e98c507 to
a60ece5
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Jan 30, 2023
Summary: Pull Request resolved: facebook#35982 This reflects better what the former `emitPartial` was doing - emitting an object with set props. ## Changelog: [Internal] [Changed] - Renamed emitPartial to emitObject Reviewed By: christophpurrer Differential Revision: D42740958 fbshipit-source-id: ce828a8ed574e82ae6b754df86e7e5776d6af38d
Summary: Pull Request resolved: facebook#35981 This reflects better what the former `emitObject` was doing - emitting a generic object. It would also allow us to rename `emitPartial` to `emitObject` in the next diff whence the function name `emitObject` will be free. ## Changelog: [Internal] [Changed] - Renamed emitObject to emitGenericObject Reviewed By: christophpurrer Differential Revision: D42740871 fbshipit-source-id: 4598182b77467c4c84d1c9a2fc5d1a177b267d69
Summary: Pull Request resolved: facebook#35982 This reflects better what the former `emitPartial` was doing - emitting an object with set props. Changelog: [INTERNAL] [CHANGED] - Renamed emitPartial to emitObject Reviewed By: christophpurrer Differential Revision: D42740958 fbshipit-source-id: 0c8948ddaaeb0af66d69871ded53110a82d2b963
|
This pull request was exported from Phabricator. Differential Revision: D42740958 |
vzaidman
force-pushed
the
export-D42740958
branch
from
a60ece5 to
0339548
Compare
|
This pull request has been merged in 112c89e. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35982 This reflects better what the former `emitPartial` was doing - emitting an object with set props. Changelog: [Internal] - Renamed emitPartial to emitObject Reviewed By: christophpurrer Differential Revision: D42740958 fbshipit-source-id: 4f974c6911bc129e698323a8039bbd7aa7602461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reflects better what the former
emitPartialwas doing - emitting an object with set props.Changelog: [INTERNAL] [CHANGED] - Renamed emitPartial to emitObject
Reviewed By: christophpurrer
Differential Revision: D42740958