Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(scripts/template/initialize): migrate to TypeScript #35990

Closed
wants to merge 6 commits into from
Closed

refactor(scripts/template/initialize): migrate to TypeScript #35990

wants to merge 6 commits into from

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Jan 27, 2023

Summary: Changelog: [Internal]

Differential Revision: D42781211

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Jan 27, 2023 •
edited
Loading

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against e0eed09

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

@analysis-bot
Copy link

analysis-bot commented Jan 27, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,464,128 +0
android hermes armeabi-v7a 7,785,487 +0
android hermes x86 8,937,955 +0
android hermes x86_64 8,796,174 +0
android jsc arm64-v8a 9,649,662 +0
android jsc armeabi-v7a 8,384,823 +0
android jsc x86 9,712,273 +0
android jsc x86_64 10,189,237 +0

Base commit: bf34810
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
ea587c0 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 5db13fc1bd90eeb4411710558de32317ccc6439b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
92ed476 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: e4db74837cdc34f52d397f528dd254bfe1a184be
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
2cb0f79 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: cd30389ca17f7d217df305bba23d92d06e3ec295
hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
242d1fb 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: ae78a582634b722a817d3ffc47d19f4236bf3499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
83d10e8 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 8bf4efec07dc459a3456b00e8987cbb8d7ea215e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
e67893f 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 3775d2a5b115bf67c3e4b7ddefd572b21dd83430
hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 30, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
3e4ffea 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 659ce94879b6e2a04c566b426976aeb72420dd1a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 31, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
3ed2798 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: a5fb8402a28d43d6dca1dc3a75743be3de4c9cd4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 31, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
30f95b2 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 25737dd40e83d9e34e9a4f34a1b26196eac4f59b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 31, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
9e14116 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 83fbe13bab859c7e9d2b804420a408a8b181bf2e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Jan 31, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
fb25d4a 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: ea3bfb778bb522a65875ce5e7c3cd56afbff0768
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

hoxyq added a commit to hoxyq/react-native that referenced this pull request Feb 1, 2023
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
4902888 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 9e21286f0081d92158a3a15fb9f8ec7395174463
hoxy and others added 6 commits February 1, 2023 05:00
@facebook-github-bot
feat(react-native-github/scripts): support ts-node & add tsconfig.json
5d8ce45 
Summary: Changelog: [Internal]

Differential Revision: D42710498

fbshipit-source-id: ee63ce7ef08129b9cae50d7a8cc37de202cf84ae
@facebook-github-bot
refactor(scripts/for-each-package) -> TypeScript
f5598da 
Summary: Changelog: [Internal]

Differential Revision: D42710497

fbshipit-source-id: 3295c10e8b85ca4a83bc0445880588870714857c
@facebook-github-bot
refactor(scripts/hermes): add tsconfig.json & rewrite scripts to TS
af1f785 
Summary: Changelog: [Internal]

Differential Revision: https://internalfb.com/D42713642

fbshipit-source-id: fd9a4ab00df5511490c6ef2910561e7b2dcf369c
@facebook-github-bot
feat(ci): added TypeScript tests
ead96bf 
Summary: Changelog: [Internal]

Differential Revision: D42781210

fbshipit-source-id: 351b06a238833298b837348e7d4c1daac4589a87
@facebook-github-bot
refactor(scripts/monorepo): -> TypeScript
cec6ec0 
Summary:
Changelog: [Internal]

Migrated scripts from `/scripts/monorepo` to TypeScript

Differential Revision: https://internalfb.com/D42776382

fbshipit-source-id: 183b448d0d56606ae7854f592b8fc111ba00f8cb
@hoxyq @facebook-github-bot
refactor(scripts/template/initialize): migrate to TypeScript (faceboo…
e0eed09 
…k#35990)

Summary:
Pull Request resolved: facebook#35990

Changelog: [Internal]

Differential Revision: D42781211

fbshipit-source-id: 701a4c1ff7992ff6cb7575de3a1d46f90666e89a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42781211

kelset
kelset reviewed Feb 6, 2023
View reviewed changes
package.json Show resolved Hide resolved
kelset
kelset reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I'm 👍 with these changes, let's just make sure to plan accordingly to cover all the *.js files (if all in this PR or if in multiples) in the /scripts folder - and that the TS config is aligned with the rest of react-native, and the template. Meaning, basically, let's make sure that @NickGerleman is 👍 too with the config

@NickGerleman
Copy link
Contributor

Let's make sure that @NickGerleman is 👍 too with the config

Yep, I've been interacting with this a bit offline, and am in support of using ts-node for the the scripts we use in CI infrastructure (and TypeScript, but not shipping ts-node usage, as part of scripts used by user-build).

kelset
kelset approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hoxyq hoxyq closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoxyq @facebook-github-bot @analysis-bot @NickGerleman @kelset