-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect touchable hitSlop and pressRetentionOffset type #36065
Conversation
Hi @bigcupcoffee! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: cab865b |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
9 similar comments
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
11 similar comments
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
We should keep the flow and typescript types in sync here. For Flow, you should be able to use |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@javache fixed another prop with exact same type, looks synced now too |
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Incorrect TS type disallows use of `hitSlop={number}`. Fixed by using Pressable's hitSlop type. NOTE: I did not bother to change Flow types in the `.js` file, please add a commit doing that if required. ## Changelog [GENERAL] [FIXED] - Fix touchable hitSlop type Pull Request resolved: #36065 Test Plan: None needed Reviewed By: christophpurrer Differential Revision: D43117689 Pulled By: javache fbshipit-source-id: 96e5ae650f47382c8d7fa1ddf63c76461c65dcc7
…ok#36065) Summary: Incorrect TS type disallows use of `hitSlop={number}`. Fixed by using Pressable's hitSlop type. NOTE: I did not bother to change Flow types in the `.js` file, please add a commit doing that if required. ## Changelog [GENERAL] [FIXED] - Fix touchable hitSlop type Pull Request resolved: facebook#36065 Test Plan: None needed Reviewed By: christophpurrer Differential Revision: D43117689 Pulled By: javache fbshipit-source-id: 96e5ae650f47382c8d7fa1ddf63c76461c65dcc7
Summary
Incorrect TS type disallows use of
hitSlop={number}
. Fixed by using Pressable's hitSlop type.NOTE: I did not bother to change Flow types in the
.js
file, please add a commit doing that if required.Changelog
[GENERAL] [FIXED] - Fix touchable hitSlop type
Test Plan
None needed