fix: remove unavailable EventEmitter TS export #36109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 7535399 |
NickGerleman
approved these changes
Feb 9, 2023
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Actually not, it was that way before RN 71 as well 🙂 |
|
@NickGerleman merged this pull request in 7b14180. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 24, 2023
Summary: Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Differential Revision: D44375081 fbshipit-source-id: 859078b71044e8a70a25062ced5c8429a63c23be
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 24, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Differential Revision: D44375081 fbshipit-source-id: 5b3f2343e8b3f224bfbc72b285f333afd45269bb
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Mar 24, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Differential Revision: D44375081 fbshipit-source-id: a75e4be326deedbeb06370860344f3c96b9a5426
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 17, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: 74e1299749da9fb920742664a0ecccd871190947
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 17, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: 4f5e2b36a42c5917cea37a6f0cd0b53420cf6b27
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Summary: Pull Request resolved: #36632 Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
kelset
pushed a commit
that referenced
this pull request
May 3, 2023
Summary: Pull Request resolved: #36632 Discovered when bumping the RN documentation to typecheck against 0.72, #36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary:
currently, using TS, this is a valid import:
`import { EventEmitter } from 'react-native';`
However, looking at the [index file](https://github.com/facebook/react-native/blob/main/index.js) we can see that there is no such export.
I first thought I'd add the EventEmitter export in order to get the `index.js` in line with the types, but it appears that the Event Emitter will become a separate package at some point facebook#34401 so removing it from the types seems to be better for future.
## Changelog
fix: remove unavailable EventEmitter TS export
Pick one each for the category and type tags:
[INTERNAL] [CHANGED] - remove unavailable EventEmitter TS export
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: facebook#36109
Test Plan: tested locally: using `import { EventEmitter } from 'react-native';` correctly gives `TS2305: Module '"react-native"' has no exported member 'EventEmitter'.`
Reviewed By: javache, cortinico
Differential Revision: D43155568
Pulled By: NickGerleman
fbshipit-source-id: b9e8c3f4be9812637c8588d14a9ce4edf188ed36
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36632 Discovered when bumping the RN documentation to typecheck against 0.72, facebook#36109 removed the `EmitterSubscription` type which should be kept public. Changelog: [General][Fixed] - Export EmitterSubscription TypeScript Type Reviewed By: cortinico Differential Revision: D44375081 fbshipit-source-id: c8dbd5694d3a728a0a2091210894d27c9d84a012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
currently, using TS, this is a valid import:
import { EventEmitter } from 'react-native';However, looking at the index file we can see that there is no such export.
I first thought I'd add the EventEmitter export in order to get the
index.jsin line with the types, but it appears that the Event Emitter will become a separate package at some point #34401 so removing it from the types seems to be better for future.Changelog
fix: remove unavailable EventEmitter TS export
Pick one each for the category and type tags:
[INTERNAL] [CHANGED] - remove unavailable EventEmitter TS export
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Test Plan
tested locally: using
import { EventEmitter } from 'react-native';correctly givesTS2305: Module '"react-native"' has no exported member 'EventEmitter'.