-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appearance.setColorScheme support (revisited) #36122
Conversation
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>
Co-authored-by: Nick Gerleman <nick@nickgerleman.com>
Base commit: 70fb2dc |
Please provide guidance on further improvements for this PR, if any. |
/rebase |
@NickGerleman should be taking care of this one. Don't you mind rebasing on top of main as the CI should be green now 👍 |
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@birkir would you be willing to add the new API to this page as well? https://github.com/facebook/react-native-website/blob/main/docs/appearance.md |
CI still broken I guess |
@NickGerleman merged this pull request in c18566f. |
Summary: After #36122 we have two of these. This change consolidates the two category methods to be part of the base RCTConvert class instead. Changelog: [iOS][Fixed] - Fix duplicate [RCTConvert UIUserInterfaceStyle:] Reviewed By: cipolleschi Differential Revision: D44050929 fbshipit-source-id: dd216545e6194446c593cd693072f3959d653d7f
Summary: Both Android and iOS allow you to set application specific user interface style, which is useful for applications that support both light and dark mode. With the newly added `Appearance.setColorScheme`, you can natively manage the application's user interface style rather than keeping that preference in JavaScript. The benefit is that native dialogs like alert, keyboard, action sheets and more will also be affected by this change. Implemented using Android X [AppCompatDelegate.setDefaultNightMode](https://developer.android.com/reference/androidx/appcompat/app/AppCompatDelegate#setDefaultNightMode(int)) and iOS 13+ [overrideUserInterfaceStyle](https://developer.apple.com/documentation/uikit/uiview/3238086-overrideuserinterfacestyle?language=objc) ```tsx // Lets assume a given device is set to **dark** mode. Appearance.getColorScheme(); // `dark` // Set the app's user interface to `light` Appearance.setColorScheme('light'); Appearance.getColorScheme(); // `light` // Set the app's user interface to `unspecified` Appearance.setColorScheme(null); Appearance.getColorScheme() // `dark` ``` ## Changelog [GENERAL] [ADDED] - Added `setColorScheme` to `Appearance` module Pull Request resolved: facebook#36122 Test Plan: Added a RNTester for the feature in the Appearance section. Three buttons for toggling all set of modes. Reviewed By: lunaleaps Differential Revision: D43331405 Pulled By: NickGerleman fbshipit-source-id: 3b15f1ed0626d1ad7a8266ec026e903cd3ec46aa
Summary: After facebook#36122 we have two of these. This change consolidates the two category methods to be part of the base RCTConvert class instead. Changelog: [iOS][Fixed] - Fix duplicate [RCTConvert UIUserInterfaceStyle:] Reviewed By: cipolleschi Differential Revision: D44050929 fbshipit-source-id: dd216545e6194446c593cd693072f3959d653d7f
Summary
Both Android and iOS allow you to set application specific user interface style, which is useful for applications that support both light and dark mode.
With the newly added
Appearance.setColorScheme
, you can natively manage the application's user interface style rather than keeping that preference in JavaScript. The benefit is that native dialogs like alert, keyboard, action sheets and more will also be affected by this change.Implemented using Android X AppCompatDelegate.setDefaultNightMode and iOS 13+ overrideUserInterfaceStyle
Changelog
[GENERAL] [ADDED] - Added
setColorScheme
toAppearance
moduleTest Plan
Added a RNTester for the feature in the Appearance section.
Three buttons for toggling all set of modes.