-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FlatList ItemSeparatorComponent type #36175
Conversation
Welp from what I see in the code |
Base commit: cb28a2c |
Does it work for FlatList, but not VirtualizedSectionList? It is does work for FlatList, but only FlatList, we could put this in FlatList typings instead of VirtualizedList typings. |
@NickGerleman I believe problem is VirtualizedSectionList does not properly override VirtualizedList's ItemSeparatorComponent type, and thus |
@NickGerleman hey, would this get any attention? I'm glad to modify the PR as long as I know what would be the best fit here |
Thanks for the contribution, @bigcupcoffee! It looks like support for elements was added in #32748. However, there are Flow type errors surfaced by Circle CI. Can you look into fixing those? I can merge this after the errors addressed. |
Also, I apologize for the delay in reviewing this. (For some reason, our internal tooling that helps surface PRs was not working correctly.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes due to Flow errors in Circle CI.
@yungsters I'm not sure how to fix the SectionList flow error, there seems to be an override already here, which should mark the prop as Component only (since Awaiting your reply about |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Summary
FlatList's ItemSeparatorComponent type did not support passing in react element as per documented in docs.
Changelog
[GENERAL] [FIXED] - Fix FlatList ItemSeparatorComponent type
Test Plan
None needed